Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty proxy for scoped section not respected when proxy is set for unscoped #442

Closed
AThomsen opened this issue Sep 7, 2021 · 0 comments · Fixed by #449
Closed

Empty proxy for scoped section not respected when proxy is set for unscoped #442

AThomsen opened this issue Sep 7, 2021 · 0 comments · Fixed by #449

Comments

@AThomsen
Copy link

AThomsen commented Sep 7, 2021

In gitconfig a default proxy is set and an exemption is made for a local server:

[http]
	proxy = http://:@<enterprise-proxy>
[http "https://<git-server-on-lan>"]
	proxy = 

This works in git but not in GCMC.

The error is in:
https://github.com/microsoft/Git-Credential-Manager-Core/blob/540a39816534e6481eaea35fe706eaa7eeb45fd8/src/shared/Microsoft.Git.CredentialManager/Settings.cs#L431-L445

GetSettingValues returns ["", "http://:@<enterprise-proxy>"].

The first value is empty, so Uri.TryCreate returns false, and thus the next value is used.

A workaround is to set NO_PROXY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant