Fill AWSManagedControlPlane.spec.network.subnets[*].id field for managed subnets for compatibility with CAPA v2.3.0
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…naged subnets for compatibility with CAPA v2.3.0
fiunchinho
approved these changes
Nov 29, 2023
1 task
calvix
approved these changes
Nov 30, 2023
(helm/cluster-eks/ci/test-wc-minimal-values.yaml) rendered manifest diff/spec/network/subnets/cidrBlock=10.0.0.0/20 (AWSManagedControlPlane/org-giantswarm/test-wc-minimal)
- one map entry removed: + one map entry added:
tags: null id: test-wc-minimal-subnet-public-a
/spec/network/subnets/cidrBlock=10.0.16.0/20 (AWSManagedControlPlane/org-giantswarm/test-wc-minimal)
- one map entry removed: + one map entry added:
tags: null id: test-wc-minimal-subnet-public-b
/spec/network/subnets/cidrBlock=10.0.32.0/20 (AWSManagedControlPlane/org-giantswarm/test-wc-minimal)
- one map entry removed: + one map entry added:
tags: null id: test-wc-minimal-subnet-public-c
/spec/network/subnets/cidrBlock=10.0.64.0/18 (AWSManagedControlPlane/org-giantswarm/test-wc-minimal)
- one map entry removed: + one map entry added:
tags: null id: test-wc-minimal-subnet-private-a
/spec/network/subnets/cidrBlock=10.0.128.0/18 (AWSManagedControlPlane/org-giantswarm/test-wc-minimal)
- one map entry removed: + one map entry added:
tags: null id: test-wc-minimal-subnet-private-b
/spec/network/subnets/cidrBlock=10.0.192.0/18 (AWSManagedControlPlane/org-giantswarm/test-wc-minimal)
- one map entry removed: + one map entry added:
tags: null id: test-wc-minimal-subnet-private-c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Towards giantswarm/roadmap#2870
Same as giantswarm/cluster-aws#439 does for cluster-aws.
Must be merged after giantswarm/cluster-api-provider-aws-app#192 is deployed.
Checklist
Trigger e2e tests
Let's trigger these later since this requires newer CAPA version.