Upgrade CAPA to v2.3.0 but comment out CRD upgrade so existing clusters reconcile fine without having the newly-required subnet id field yet
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs reconcile fine without having the newly-required subent `id` field yet
This was referenced Nov 28, 2023
fiunchinho
approved these changes
Nov 29, 2023
AndiDog
changed the title
id field yetid field yet
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#2870, namely the first step of the suggested migration.
Note that since the old CRDs are used here, avoiding that the subnet
idfield is required for now, themake verifyCI job is failing. That must be accepted until step two (update to actual, latest CRDs which make the field required).See related cluster app changes:
AWSCluster.spec.network.subnets[*].idfield for managed subnets for compatibility with CAPA v2.3.0 cluster-aws#439AWSManagedControlPlane.spec.network.subnets[*].idfield for managed subnets for compatibility with CAPA v2.3.0 cluster-eks#43Checklist