Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting merge functions from apptestctl #62

Merged
merged 4 commits into from
Dec 3, 2020
Merged

Deleting merge functions from apptestctl #62

merged 4 commits into from
Dec 3, 2020

Conversation

tomahawk28
Copy link
Contributor

Deleting helmclient.Merge from apptestctl so we can deprecate that function.

@tomahawk28 tomahawk28 self-assigned this Dec 3, 2020
@tomahawk28 tomahawk28 requested a review from a team December 3, 2020 15:50
@tomahawk28
Copy link
Contributor Author

Tested with local kind cluster, works fine.

rossf7
rossf7 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a changelog

@tomahawk28 tomahawk28 merged commit 2983d74 into master Dec 3, 2020
@tomahawk28 tomahawk28 deleted the purge-merge-value-funcions branch December 3, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossf7 rossf7 rossf7 approved these changes

Assignees

@tomahawk28 tomahawk28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomahawk28 @rossf7