Skip to content

Commit

Permalink
Deleting merge functions from apptestctl (#62)
Browse files Browse the repository at this point in the history
* deleting merge functions from apptestctl

* adding changelog

* Update cmd/bootstrap/runner.go

Co-authored-by: Ross Fairbanks <[email protected]>

* remove whitespaces (2)

Co-authored-by: Ross Fairbanks <[email protected]>
  • Loading branch information
tomahawk28 and rossf7 authored Dec 3, 2020
1 parent ca2bd08 commit 2983d74
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Remove helmclient.MergeValue functions usage.

## [0.5.2] - 2020-12-01

### Changed
Expand Down
11 changes: 5 additions & 6 deletions cmd/bootstrap/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -568,11 +568,10 @@ func (r *runner) installOperator(ctx context.Context, helmClient helmclient.Inte
r.logger.LogCtx(ctx, "level", "debug", "message", fmt.Sprintf("installing %#q", name))

// Set control plane operator values so chart-operator DNS settings are
// correct. Merge with an empty set of values so YAML is parsed.
input := map[string][]byte{
"values": []byte(operatorValuesYAML),
}
values, err := helmclient.MergeValues(input, map[string][]byte{})
// correct.
var input map[string]interface{}

err := yaml.Unmarshal([]byte(operatorValuesYAML), &input)
if err != nil {
return microerror.Mask(err)
}
Expand All @@ -587,7 +586,7 @@ func (r *runner) installOperator(ctx context.Context, helmClient helmclient.Inte
err = helmClient.InstallReleaseFromTarball(ctx,
operatorTarballPath,
namespace,
values,
input,
opts)
if helmclient.IsCannotReuseRelease(err) {
r.logger.LogCtx(ctx, "level", "debug", "message", fmt.Sprintf("%#q already installed", name))
Expand Down

0 comments on commit 2983d74

Please sign in to comment.