Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llava : zero-initialize clip_ctx structure fields with aggregate initialization #9082

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

fairydreaming
Copy link
Collaborator

Without the initialization struct fields have garbage values causing crashes reported in #9066.
Fixes #9066.

@LostRuins
Copy link
Collaborator

@fairydreaming what about

-                patches_data[i] = i + 1;
+                patches_data[i] = i;

Is that worth changing as well?

@fairydreaming
Copy link
Collaborator Author

@LostRuins Not until we find what is the purpose of this code and how to properly fix it.

@fairydreaming fairydreaming merged commit f63f603 into ggerganov:master Aug 21, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MiniCPM-V-2.6 commit d565bb2fd5a2a58b9924a7a34e77a87c78c52137 causing crash in moondream
4 participants