Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llava : fix occasional undefined behavior crash #9078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jart
Copy link
Contributor

@jart jart commented Aug 18, 2024

Nice simple bug fix for you.

@fairydreaming
Copy link
Collaborator

Just wanted to note that this is yet another solution that fixes #9066 by zero-initializing the load_image_size field of the clip_ctx structure. PR #9082 does the same, but zero-initializes all clip_ctx fields that have no default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MiniCPM-V-2.6 commit d565bb2fd5a2a58b9924a7a34e77a87c78c52137 causing crash in moondream
2 participants