Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme sycl for new update #6151

Merged
merged 11 commits into from
Mar 20, 2024
Merged

update readme sycl for new update #6151

merged 11 commits into from
Mar 20, 2024

Conversation

NeoZhangJianyu
Copy link
Collaborator

  1. Update guide to set main GPU.
  2. Update example log for new list device format.
  3. Ask to add [SYCL] prefix in issue tile.

@NeoZhangJianyu NeoZhangJianyu requested a review from airMeng March 19, 2024 02:02
@NeoZhangJianyu
Copy link
Collaborator Author

@luoyu-intel @abhilash1910 please help review!

@airMeng
Copy link
Collaborator

airMeng commented Mar 19, 2024

seems conflict with #6141

@airMeng airMeng requested a review from ngxson March 19, 2024 02:45
abhilash1910
abhilash1910 reviewed Mar 19, 2024
View reviewed changes
README-sycl.md Outdated Show resolved Hide resolved
abhilash1910
abhilash1910 reviewed Mar 19, 2024
View reviewed changes
README-sycl.md Outdated Show resolved Hide resolved
abhilash1910
abhilash1910 reviewed Mar 19, 2024
View reviewed changes
README-sycl.md Outdated Show resolved Hide resolved
abhilash1910
abhilash1910 reviewed Mar 19, 2024
View reviewed changes
README-sycl.md Outdated Show resolved Hide resolved
abhilash1910
abhilash1910 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@abhilash1910 abhilash1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! some cosmetic changes

NeoZhangJianyu and others added 4 commits March 19, 2024 16:56
@NeoZhangJianyu @abhilash1910
Update README-sycl.md
6299e8d 
Co-authored-by: Abhilash Majumder <[email protected]>
@NeoZhangJianyu @abhilash1910
Update README-sycl.md
634e3fc 
Co-authored-by: Abhilash Majumder <[email protected]>
@NeoZhangJianyu @abhilash1910
Update README-sycl.md
28b6f88 
Co-authored-by: Abhilash Majumder <[email protected]>
@NeoZhangJianyu @abhilash1910
Update README-sycl.md
60392d7 
Co-authored-by: Abhilash Majumder <[email protected]>
@NeoZhangJianyu
Copy link
Collaborator Author

seems conflict with #6141

The PR has more changed and comments.
I suggest not to wait for it.

ngxson
ngxson reviewed Mar 19, 2024
View reviewed changes
README-sycl.md Show resolved Hide resolved
AidanBeltonS
AidanBeltonS approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording changes

README-sycl.md Outdated Show resolved Hide resolved
README-sycl.md Outdated Show resolved Hide resolved
README-sycl.md Outdated Show resolved Hide resolved
README-sycl.md Outdated Show resolved Hide resolved
airMeng
airMeng approved these changes Mar 20, 2024
View reviewed changes
README-sycl.md Outdated Show resolved Hide resolved
@NeoZhangJianyu @airMeng
Update README-sycl.md
37db7ef 
Co-authored-by: Meng, Hengyu <[email protected]>
@NeoZhangJianyu NeoZhangJianyu merged commit 6c0b287 into ggerganov:master Mar 20, 2024
21 checks passed
@OuadiElfarouki OuadiElfarouki mentioned this pull request Mar 20, 2024
Merged
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
@NeoZhangJianyu @abhilash1910
@AidanBeltonS @airMeng @hodlen
update readme sycl for new update (ggerganov#6151)
6356473 
* update readme sycl for new update

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: AidanBeltonS <[email protected]>

* Update README-sycl.md

Co-authored-by: AidanBeltonS <[email protected]>

* update by review comments

* update w64devkit link

* update for verify device id part

* Update README-sycl.md

Co-authored-by: Meng, Hengyu <[email protected]>

---------

Co-authored-by: Abhilash Majumder <[email protected]>
Co-authored-by: AidanBeltonS <[email protected]>
Co-authored-by: Meng, Hengyu <[email protected]>
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
@NeoZhangJianyu @abhilash1910
@AidanBeltonS @airMeng @hodlen
update readme sycl for new update (ggerganov#6151)
076d0c2 
* update readme sycl for new update

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: AidanBeltonS <[email protected]>

* Update README-sycl.md

Co-authored-by: AidanBeltonS <[email protected]>

* update by review comments

* update w64devkit link

* update for verify device id part

* Update README-sycl.md

Co-authored-by: Meng, Hengyu <[email protected]>

---------

Co-authored-by: Abhilash Majumder <[email protected]>
Co-authored-by: AidanBeltonS <[email protected]>
Co-authored-by: Meng, Hengyu <[email protected]>
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
@NeoZhangJianyu @abhilash1910
@AidanBeltonS @airMeng @tybalex
update readme sycl for new update (ggerganov#6151)
27160fc 
* update readme sycl for new update

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: Abhilash Majumder <[email protected]>

* Update README-sycl.md

Co-authored-by: AidanBeltonS <[email protected]>

* Update README-sycl.md

Co-authored-by: AidanBeltonS <[email protected]>

* update by review comments

* update w64devkit link

* update for verify device id part

* Update README-sycl.md

Co-authored-by: Meng, Hengyu <[email protected]>

---------

Co-authored-by: Abhilash Majumder <[email protected]>
Co-authored-by: AidanBeltonS <[email protected]>
Co-authored-by: Meng, Hengyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luoyu-intel luoyu-intel luoyu-intel left review comments

@AidanBeltonS AidanBeltonS AidanBeltonS approved these changes

@airMeng airMeng airMeng approved these changes

@abhilash1910 abhilash1910 abhilash1910 approved these changes

@ngxson ngxson ngxson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NeoZhangJianyu @airMeng @ngxson @abhilash1910 @AidanBeltonS @luoyu-intel