-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Revisited & updated SYCL build documentation #6141
[SYCL] Revisited & updated SYCL build documentation #6141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With changes it LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice job. Thanks!
Branch has been rebased, some conflicts with #6151 have been addressed locally. |
@OuadiElfarouki
Because some my comments are unavailable due to the line number is changed. |
@AidanBeltonS |
* Revisited & updated SYCL build documentation * removed outdated comment * Addressed PR comments * Trimed white spaces * added new end line
* Revisited & updated SYCL build documentation * removed outdated comment * Addressed PR comments * Trimed white spaces * added new end line
* Revisited & updated SYCL build documentation * removed outdated comment * Addressed PR comments * Trimed white spaces * added new end line
Updated the README-sycl.md, fixed typos and added more clarifications for the different build targets (intel GPUs & Nvidia GPUs so far).
Please let me know what you think @NeoZhangJianyu @airMeng @AidanBeltonS @abhilash1910