Use sendDefaultPii=true for Java SDK onboarding
#85141
Conversation
github-actions
bot
added
the
Scope: Frontend
| @@ -64,6 +64,9 @@ const getConfigurationSnippet = (params: Params) => ` | |||
| <!-- Required: set your sentry.io project identifier (DSN) --> | |||
| <meta-data android:name="io.sentry.dsn" android:value="${params.dsn.public}" /> | |||
|
|
|||
| <!-- Add data like request headers and device name, see https://docs.sentry.io/platforms/android/data-management/data-collected/ for more info --> | |||
| <meta-data android:name="io.sentry.send-default-pii" android:value="true" /> | |||
There was a problem hiding this comment.
There's also the wizard where I couldn't find any trace of the PII setting being suggested / enabled.
There was a problem hiding this comment.
Yep, probably we could add send-default-pii=true to the sentry.properties created by the Wizard, commented out and with a comment above it that explains what it does (out of scope for this PR ofc).
There was a problem hiding this comment.
I opened an issue for the wizard changes: getsentry/sentry-wizard#790
| dsn=${params.dsn.public} | ||
| # Add data like request headers and IP for users, | ||
| # see https://docs.sentry.io/platforms/java/guides/log4j2/data-management/data-collected/ for more info | ||
| send-defaut-pii=true${ | ||
| params.isPerformanceSelected | ||
| ? ` | ||
| traces-sample-rate=1.0` |
There was a problem hiding this comment.
There's still a sample without sendDefaultPii here. While it would be possible to change the SDK and add that option to the XML config I think it's better to just use sentry.properties instead as that already existed for a while and doesn't require use of a new version of the SDK.
|
Marked this as a draft because getsentry/sentry-docs#12704 needs to be merged first. |
| @@ -64,6 +64,9 @@ const getConfigurationSnippet = (params: Params) => ` | |||
| <!-- Required: set your sentry.io project identifier (DSN) --> | |||
| <meta-data android:name="io.sentry.dsn" android:value="${params.dsn.public}" /> | |||
|
|
|||
| <!-- Add data like request headers and device name, see https://docs.sentry.io/platforms/android/data-management/data-collected/ for more info --> | |||
| <meta-data android:name="io.sentry.send-default-pii" android:value="true" /> | |||
There was a problem hiding this comment.
Yep, probably we could add send-default-pii=true to the sentry.properties created by the Wizard, commented out and with a comment above it that explains what it does (out of scope for this PR ofc).
Co-authored-by: Lorenzo Cian <[email protected]>
Bundle ReportChanges will increase total bundle size by 3.83kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
|
Co-authored-by: Markus Hintersteiner <[email protected]>
Closes getsentry/sentry-java#4119
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.