Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendDefaultPii=true for Java/Android in getting started docs #12727

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

adinauer
Copy link
Member

Docs part of getsentry/sentry-java#4119
There's also the in product onboarding docs as a separate PR: getsentry/sentry#85141

All of these PRs need the docs about what data the SDK collects to be merged first so this is still marked as a draft for now. It is however ready to be reviewed.

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 10:54am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 10:54am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 10:54am

@adinauer adinauer marked this pull request as draft February 14, 2025 11:27
Copy link

codecov bot commented Feb 14, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/fGGETPoI38Xa85FmWBi89/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/fGGETPoI38Xa85FmWBi89/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

<application>
<!-- Required: set your sentry.io project identifier (DSN) -->
<meta-data android:name="io.sentry.dsn" android:value="___PUBLIC_DSN___" />
<!-- Add data like request headers and device name, see https://docs.sentry.io/platforms/android/data-management/data-collected/ for more info -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m I think we should also add this to the manual setup page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, see below

@kahest kahest requested a review from markushi February 17, 2025 09:34
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Markus Hintersteiner <[email protected]>
@adinauer adinauer marked this pull request as ready for review February 17, 2025 13:31
@adinauer adinauer merged commit 1144c95 into master Feb 17, 2025
11 checks passed
@adinauer adinauer deleted the feat/java-send-default-pii-getting-started branch February 17, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants