Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): fix expo sample version to 52.0.19 #4592

Closed
wants to merge 1 commit into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Feb 25, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #4568

📜 Description

Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.

e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible.  Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context

Ci failures

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis
Copy link
Collaborator Author

antonis commented Feb 25, 2025

Note that the type test failures are fixed by #4587

@antonis antonis changed the title chore(dep): fix expo version to 52.0.19 chore(dep): fix expo sample version to 52.0.19 Feb 25, 2025
@antonis antonis marked this pull request as ready for review February 25, 2025 09:04
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 370.15 ms 398.72 ms 28.58 ms
Size 17.75 MiB 20.10 MiB 2.36 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

Revision Plain With Sentry Diff
71f7309 412.45 ms 431.62 ms 19.18 ms
e54b1ed 434.79 ms 429.52 ms -5.27 ms
345e497 397.98 ms 423.40 ms 25.42 ms

App size

Revision Plain With Sentry Diff
71f7309 17.75 MiB 20.10 MiB 2.36 MiB
e54b1ed 17.75 MiB 20.10 MiB 2.36 MiB
345e497 17.75 MiB 20.10 MiB 2.36 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1206.62 ms 1213.94 ms 7.32 ms
Size 2.63 MiB 3.73 MiB 1.10 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

Revision Plain With Sentry Diff
e54b1ed+dirty 1227.33 ms 1254.46 ms 27.14 ms
345e497+dirty 1218.83 ms 1218.73 ms -0.10 ms
71f7309+dirty 1222.02 ms 1224.81 ms 2.79 ms

App size

Revision Plain With Sentry Diff
e54b1ed+dirty 2.63 MiB 3.68 MiB 1.05 MiB
345e497+dirty 2.63 MiB 3.68 MiB 1.05 MiB
71f7309+dirty 2.63 MiB 3.73 MiB 1.10 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.45 ms 349.43 ms -7.02 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

Revision Plain With Sentry Diff
345e497+dirty 375.33 ms 377.23 ms 1.90 ms
71f7309+dirty 361.15 ms 369.90 ms 8.75 ms
e54b1ed+dirty 435.06 ms 429.19 ms -5.87 ms

App size

Revision Plain With Sentry Diff
345e497+dirty 7.15 MiB 8.37 MiB 1.22 MiB
71f7309+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e54b1ed+dirty 7.15 MiB 8.37 MiB 1.22 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.62 ms 1221.76 ms -4.87 ms
Size 3.19 MiB 4.30 MiB 1.11 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

Revision Plain With Sentry Diff
e54b1ed+dirty 1227.90 ms 1230.92 ms 3.02 ms
345e497+dirty 1210.67 ms 1207.50 ms -3.17 ms
71f7309+dirty 1206.00 ms 1214.28 ms 8.28 ms

App size

Revision Plain With Sentry Diff
e54b1ed+dirty 3.19 MiB 4.25 MiB 1.06 MiB
345e497+dirty 3.19 MiB 4.25 MiB 1.06 MiB
71f7309+dirty 3.19 MiB 4.30 MiB 1.11 MiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.

When have we updated to 52.0.37 as this is not an issue on main at the moment?

@krystofwoldrich
Copy link
Member

I see it's coming from #4568

We should check the yarn.lock changes, there should not be so many changes.

@antonis
Copy link
Collaborator Author

antonis commented Feb 25, 2025

When have we updated to 52.0.37

I've tested 52.0.37 and the issue persists.

as this is not an issue on main at the moment?

I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔

@krystofwoldrich
Copy link
Member

Yes, we should avoid updating unrelated deps in #4568

After the yarn.lock is fixed in #4568 this PR should not be needed.

@antonis
Copy link
Collaborator Author

antonis commented Feb 25, 2025

Closing as per #4592 (comment)

@antonis antonis closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants