(WIP) Feat: Sentry Javascript V9 #4568
Open
+258
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309+dirty | 1222.02 ms | 1224.81 ms | 2.79 ms |
| 345e497+dirty | 1218.83 ms | 1218.73 ms | -0.10 ms |
| e54b1ed+dirty | 1227.33 ms | 1254.46 ms | 27.14 ms |
| 987dc4d+dirty | 1216.13 ms | 1227.20 ms | 11.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309+dirty | 2.63 MiB | 3.73 MiB | 1.10 MiB |
| 345e497+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| e54b1ed+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 987dc4d+dirty | 2.63 MiB | 3.73 MiB | 1.10 MiB |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309 | 412.45 ms | 431.62 ms | 19.18 ms |
| 345e497 | 397.98 ms | 423.40 ms | 25.42 ms |
| e54b1ed | 434.79 ms | 429.52 ms | -5.27 ms |
| 987dc4d | 422.12 ms | 478.34 ms | 56.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| 345e497 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| e54b1ed | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| 987dc4d | 17.75 MiB | 20.10 MiB | 2.36 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497+dirty | 375.33 ms | 377.23 ms | 1.90 ms |
| 71f7309+dirty | 361.15 ms | 369.90 ms | 8.75 ms |
| e54b1ed+dirty | 435.06 ms | 429.19 ms | -5.87 ms |
| 987dc4d+dirty | 411.89 ms | 418.60 ms | 6.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 71f7309+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| e54b1ed+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 987dc4d+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309+dirty | 1206.00 ms | 1214.28 ms | 8.28 ms |
| 345e497+dirty | 1210.67 ms | 1207.50 ms | -3.17 ms |
| e54b1ed+dirty | 1227.90 ms | 1230.92 ms | 3.02 ms |
| 987dc4d+dirty | 1209.94 ms | 1215.25 ms | 5.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309+dirty | 3.19 MiB | 4.30 MiB | 1.11 MiB |
| 345e497+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| e54b1ed+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 987dc4d+dirty | 3.19 MiB | 4.30 MiB | 1.11 MiB |
10 tasks
|
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK |
10 tasks
|
@lucas-zimerman The How have you upgraded to the JS v9? We should review it and ensure only the The |
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR |
|
Thank you @lucas-zimerman, now the |
lucas-zimerman
commented
Feb 25, 2025
|
@antonis @krystofwoldrich I'd say now it's ready for review :D |
antonis
reviewed
Feb 26, 2025
antonis
reviewed
Feb 26, 2025
antonis
approved these changes
Feb 26, 2025
…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.
In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog for now