Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal(sample-rn): Add Detox for integration/e2e tests of the rn sample #4535

Merged
merged 3 commits into from
Feb 14, 2025
Merged

internal(sample-rn): Add Detox for integration/e2e tests of the rn sample #4535

merged 3 commits into from
Feb 14, 2025

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Feb 13, 2025 •
edited
Loading

📢 Type of change

  • Enhancement

📜 Description

This PR adds Detox tests to samples/react-native.

We need Detox due to limited assertions on JS objects in Maestro and the inability to run the Mocked relay as part of the tests.

The actual tests are part of the following PR #4536

How to build and run the tests?

detox build --configuration ios.sim.release
detox test --configuration ios.sim.release

detox build --configuration android.emu.release
detox test --configuration android.emu.release

Other configurations are described in .detoxrc.js.

💚 How did you test it?

run tests locally and set up new job in CI to run the tests

#skip-changelog

@krystofwoldrich krystofwoldrich changed the title ref(ios): Extract Cocoa SDK init into standalone file (#4442) internal(sample-rn): Add Detox for integration/e2e tests of the rn sample Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 404.12 ms 438.12 ms 34.00 ms
Size 17.75 MiB 20.11 MiB 2.37 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
1a89392 412.59 ms 424.69 ms 12.10 ms
555070f 438.67 ms 428.30 ms -10.37 ms
5625ce7 476.74 ms 488.24 ms 11.50 ms
b75148e 440.04 ms 421.36 ms -18.68 ms
208f4af 439.23 ms 427.31 ms -11.92 ms
b6d933c 442.52 ms 461.82 ms 19.30 ms
18a5066 427.89 ms 436.47 ms 8.57 ms

App size

Revision Plain With Sentry Diff
1a89392 17.75 MiB 20.11 MiB 2.37 MiB
555070f 17.75 MiB 20.11 MiB 2.37 MiB
5625ce7 17.75 MiB 20.11 MiB 2.37 MiB
b75148e 17.75 MiB 20.11 MiB 2.37 MiB
208f4af 17.75 MiB 20.11 MiB 2.37 MiB
b6d933c 17.75 MiB 20.11 MiB 2.37 MiB
18a5066 17.75 MiB 20.11 MiB 2.37 MiB

Previous results on branch: add-detox-to-sample

Startup times

Revision Plain With Sentry Diff
47299fb 407.02 ms 437.88 ms 30.86 ms

App size

Revision Plain With Sentry Diff
47299fb 17.75 MiB 20.11 MiB 2.37 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.08 ms 1214.41 ms 1.32 ms
Size 2.63 MiB 3.70 MiB 1.06 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
b75148e+dirty 1221.53 ms 1220.85 ms -0.68 ms
208f4af+dirty 1209.44 ms 1217.13 ms 7.70 ms
1a89392+dirty 1220.12 ms 1216.69 ms -3.43 ms
18a5066+dirty 1218.00 ms 1212.27 ms -5.73 ms
5625ce7+dirty 1226.98 ms 1217.77 ms -9.21 ms
555070f+dirty 1213.59 ms 1217.79 ms 4.20 ms
b6d933c+dirty 1217.71 ms 1220.58 ms 2.87 ms

App size

Revision Plain With Sentry Diff
b75148e+dirty 2.63 MiB 3.69 MiB 1.06 MiB
208f4af+dirty 2.63 MiB 3.69 MiB 1.05 MiB
1a89392+dirty 2.63 MiB 3.70 MiB 1.06 MiB
18a5066+dirty 2.63 MiB 3.70 MiB 1.06 MiB
5625ce7+dirty 2.63 MiB 3.70 MiB 1.06 MiB
555070f+dirty 2.63 MiB 3.69 MiB 1.05 MiB
b6d933c+dirty 2.63 MiB 3.70 MiB 1.06 MiB

Previous results on branch: add-detox-to-sample

Startup times

Revision Plain With Sentry Diff
47299fb+dirty 1229.29 ms 1224.49 ms -4.80 ms

App size

Revision Plain With Sentry Diff
47299fb+dirty 2.63 MiB 3.70 MiB 1.06 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 370.07 ms 359.24 ms -10.82 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
208f4af+dirty 346.93 ms 402.77 ms 55.84 ms
18a5066+dirty 370.06 ms 414.10 ms 44.04 ms
1a89392+dirty 425.56 ms 530.65 ms 105.09 ms
5625ce7+dirty 358.15 ms 416.65 ms 58.50 ms
b6d933c+dirty 398.43 ms 456.62 ms 58.19 ms
555070f+dirty 388.25 ms 424.44 ms 36.19 ms
b75148e+dirty 428.91 ms 461.26 ms 32.35 ms

App size

Revision Plain With Sentry Diff
208f4af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
18a5066+dirty 7.15 MiB 8.38 MiB 1.23 MiB
1a89392+dirty 7.15 MiB 8.38 MiB 1.23 MiB
5625ce7+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b6d933c+dirty 7.15 MiB 8.38 MiB 1.23 MiB
555070f+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b75148e+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: add-detox-to-sample

Startup times

Revision Plain With Sentry Diff
47299fb+dirty 398.39 ms 443.59 ms 45.20 ms

App size

Revision Plain With Sentry Diff
47299fb+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.34 ms 1230.78 ms -1.56 ms
Size 3.19 MiB 4.26 MiB 1.08 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
b75148e+dirty 1202.72 ms 1212.04 ms 9.32 ms
208f4af+dirty 1213.08 ms 1223.82 ms 10.73 ms
1a89392+dirty 1229.00 ms 1234.78 ms 5.78 ms
18a5066+dirty 1244.20 ms 1251.54 ms 7.34 ms
5625ce7+dirty 1219.73 ms 1223.80 ms 4.07 ms
555070f+dirty 1223.61 ms 1227.57 ms 3.96 ms
b6d933c+dirty 1228.02 ms 1235.32 ms 7.30 ms

App size

Revision Plain With Sentry Diff
b75148e+dirty 3.19 MiB 4.25 MiB 1.07 MiB
208f4af+dirty 3.19 MiB 4.25 MiB 1.06 MiB
1a89392+dirty 3.19 MiB 4.26 MiB 1.08 MiB
18a5066+dirty 3.19 MiB 4.26 MiB 1.08 MiB
5625ce7+dirty 3.19 MiB 4.26 MiB 1.08 MiB
555070f+dirty 3.19 MiB 4.25 MiB 1.06 MiB
b6d933c+dirty 3.19 MiB 4.26 MiB 1.08 MiB

Previous results on branch: add-detox-to-sample

Startup times

Revision Plain With Sentry Diff
47299fb+dirty 1219.47 ms 1220.04 ms 0.58 ms

App size

Revision Plain With Sentry Diff
47299fb+dirty 3.19 MiB 4.26 MiB 1.08 MiB

@krystofwoldrich krystofwoldrich mentioned this pull request Feb 14, 2025
Closed
10 tasks
@krystofwoldrich krystofwoldrich marked this pull request as ready for review February 14, 2025 09:33
antonis
antonis approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM and the CI jobs run as expected 🚀
Thank you for adding Detox to our testing arsenal 🙇

@krystofwoldrich krystofwoldrich merged commit 28cf7b4 into capture-app-start-errors Feb 14, 2025
68 checks passed
@krystofwoldrich krystofwoldrich deleted the add-detox-to-sample branch February 14, 2025 15:27
krystofwoldrich added a commit that referenced this pull request Mar 3, 2025
@krystofwoldrich
internal(sample-rn): Add Detox for integration/e2e tests of the rn sa…
ab5cdfe 
…mple (#4535)
@krystofwoldrich krystofwoldrich mentioned this pull request Mar 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @antonis