Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Add Detox and Envelope snapshot testing #4526

Closed

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add Detox and Envelope snapshot testing ([#4526](https://github.com/getsentry/sentry-react-native/pull/4526))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 68558db

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 468.39 ms 489.12 ms 20.73 ms
Size 17.75 MiB 20.11 MiB 2.37 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
1a89392 412.59 ms 424.69 ms 12.10 ms
555070f 438.67 ms 428.30 ms -10.37 ms
5625ce7 476.74 ms 488.24 ms 11.50 ms
b75148e 440.04 ms 421.36 ms -18.68 ms
208f4af 439.23 ms 427.31 ms -11.92 ms
b6d933c 442.52 ms 461.82 ms 19.30 ms
18a5066 427.89 ms 436.47 ms 8.57 ms

App size

Revision Plain With Sentry Diff
1a89392 17.75 MiB 20.11 MiB 2.37 MiB
555070f 17.75 MiB 20.11 MiB 2.37 MiB
5625ce7 17.75 MiB 20.11 MiB 2.37 MiB
b75148e 17.75 MiB 20.11 MiB 2.37 MiB
208f4af 17.75 MiB 20.11 MiB 2.37 MiB
b6d933c 17.75 MiB 20.11 MiB 2.37 MiB
18a5066 17.75 MiB 20.11 MiB 2.37 MiB

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 367.25 ms 406.18 ms 38.93 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Copy link
Contributor

github-actions bot commented Feb 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.96 ms 1220.82 ms 4.86 ms
Size 3.19 MiB 4.26 MiB 1.08 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
b75148e+dirty 1202.72 ms 1212.04 ms 9.32 ms
208f4af+dirty 1213.08 ms 1223.82 ms 10.73 ms
1a89392+dirty 1229.00 ms 1234.78 ms 5.78 ms
18a5066+dirty 1244.20 ms 1251.54 ms 7.34 ms
5625ce7+dirty 1219.73 ms 1223.80 ms 4.07 ms
555070f+dirty 1223.61 ms 1227.57 ms 3.96 ms
b6d933c+dirty 1228.02 ms 1235.32 ms 7.30 ms

App size

Revision Plain With Sentry Diff
b75148e+dirty 3.19 MiB 4.25 MiB 1.07 MiB
208f4af+dirty 3.19 MiB 4.25 MiB 1.06 MiB
1a89392+dirty 3.19 MiB 4.26 MiB 1.08 MiB
18a5066+dirty 3.19 MiB 4.26 MiB 1.08 MiB
5625ce7+dirty 3.19 MiB 4.26 MiB 1.08 MiB
555070f+dirty 3.19 MiB 4.25 MiB 1.06 MiB
b6d933c+dirty 3.19 MiB 4.26 MiB 1.08 MiB

Copy link
Contributor

github-actions bot commented Feb 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.43 ms 1220.06 ms -1.36 ms
Size 2.63 MiB 3.70 MiB 1.06 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
b75148e+dirty 1221.53 ms 1220.85 ms -0.68 ms
208f4af+dirty 1209.44 ms 1217.13 ms 7.70 ms
1a89392+dirty 1220.12 ms 1216.69 ms -3.43 ms
18a5066+dirty 1218.00 ms 1212.27 ms -5.73 ms
5625ce7+dirty 1226.98 ms 1217.77 ms -9.21 ms
555070f+dirty 1213.59 ms 1217.79 ms 4.20 ms
b6d933c+dirty 1217.71 ms 1220.58 ms 2.87 ms

App size

Revision Plain With Sentry Diff
b75148e+dirty 2.63 MiB 3.69 MiB 1.06 MiB
208f4af+dirty 2.63 MiB 3.69 MiB 1.05 MiB
1a89392+dirty 2.63 MiB 3.70 MiB 1.06 MiB
18a5066+dirty 2.63 MiB 3.70 MiB 1.06 MiB
5625ce7+dirty 2.63 MiB 3.70 MiB 1.06 MiB
555070f+dirty 2.63 MiB 3.69 MiB 1.05 MiB
b6d933c+dirty 2.63 MiB 3.70 MiB 1.06 MiB

Base automatically changed from kw/sample-native-auto-init-switch to capture-app-start-errors February 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant