Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sveltekit): Add SvelteKit 2.0 E2E test app #9873

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 15, 2023

Requires #9872 to be merged first but otherwise ready for review.

This PR adds a Sveltekit 2.0 E2E test application. Currently, we only test building. This shows that with #9872, our SDK works in SvelteKit 2.0. We should however add actual tests to both Kit 1.x and 2.x test apps. Will take a look at it this week. Maybe also canary tests, let's se...

@Lms24 Lms24 changed the base branch from develop to lms/fix-sveltekit-2-exports December 15, 2023 15:59
@Lms24 Lms24 force-pushed the lms/test-sveltekit-2.0-e2e-tests branch from 494ddc3 to ef2ba96 Compare December 15, 2023 16:50
Copy link
Contributor

github-actions bot commented Dec 15, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.14 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.57 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.16 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.23 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.85 KB (0%)
@sentry/browser - Webpack (gzipped) 21.53 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.57 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.28 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.54 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.59 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.16 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.26 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.31 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.4 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.92 KB (0%)
@sentry/react - Webpack (gzipped) 21.57 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.71 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 48.39 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.18 KB (0%)

@Lms24 Lms24 changed the title test(sveltekit): Add SvelteKit 2.0 E2E test test(sveltekit): Add SvelteKit 2.0 E2E test app Dec 15, 2023
@Lms24 Lms24 marked this pull request as ready for review December 18, 2023 11:08
@Lms24 Lms24 requested review from mydea and lforst December 18, 2023 11:08
@Lms24 Lms24 mentioned this pull request Dec 18, 2023
@Lms24 Lms24 self-assigned this Dec 18, 2023
@Lms24 Lms24 force-pushed the lms/fix-sveltekit-2-exports branch 2 times, most recently from 9d920da to 81563d0 Compare December 19, 2023 10:52
Base automatically changed from lms/fix-sveltekit-2-exports to develop December 19, 2023 11:20
@Lms24 Lms24 force-pushed the lms/test-sveltekit-2.0-e2e-tests branch from 8e9ef54 to 4c042ea Compare December 19, 2023 12:06
@Lms24 Lms24 enabled auto-merge (squash) December 19, 2023 12:07
@Lms24 Lms24 merged commit 31c769c into develop Dec 19, 2023
95 checks passed
@Lms24 Lms24 deleted the lms/test-sveltekit-2.0-e2e-tests branch December 19, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants