fix(sveltekit): Add conditional exports #9872
Conversation
packages/sveltekit/package.json
Outdated
| "exports": { | ||
| "browser": "./build/esm/index.client.js", | ||
| "node": "./build/cjs/index.server.js" | ||
| }, |
There was a problem hiding this comment.
Wondering if we should have esm and cjs for both browser and node... (by adding objects with import and require fields)
There was a problem hiding this comment.
we should.
Ideally exports fields look something like so:
(from https://abhiprasad.github.io/talks/2023/publishing-javascript-libraries-made-easy.pdf)
I don't think we can get the types separated, so we can ignore that field.
There was a problem hiding this comment.
Actually esm is broken because of our http integration, so maybe we just dont expose that for now.
There was a problem hiding this comment.
We can get rid of the http integration but iirc there's also a require call in our http transport which we can't just get rid of 🤔
There was a problem hiding this comment.
@AbhiPrasad what's the advantage of the package.json export?
There was a problem hiding this comment.
@AbhiPrasad so we want this (considering server-side ESM is broken), correct?
There was a problem hiding this comment.
Tested the version from the screenshot and it still seems to work so going with it.
Lms24
force-pushed
the
lms/fix-sveltekit-2-exports
branch
from
7b7a664 to
9d920da
Compare
Lms24
force-pushed
the
lms/fix-sveltekit-2-exports
branch
from
9d920da to
81563d0
Compare
adds a Sveltekit 2.0 E2E test application. Currently, we only test building. This shows that with #9872, our SDK works in SvelteKit 2.0. We should however add actual tests to both Kit 1.x and 2.x test apps.
Looks like Vite 5 module resolution for
@sentry/sveltekitonly works with defining conditional exports. Tested this locally with a Sverdle kit@1, kit@2 and the syntax website.It'd be nice to get confirmation that this fixes syntaxfm/website#1458 but based on my tests it should be fine 🤞
Added an e2e test for Kit 2.0 in #9873
ref #9851