Polyfills Bailout: Part 1

packages/browser/src/integrations/breadcrumbs.ts

@@ -236,7 +236,7 @@ export class Breadcrumbs implements Integration {
           const filterUrl = new API(dsn).getStoreEndpoint();
           // if Sentry key appears in URL, don't capture it as a request
           // but rather as our own 'sentry' type breadcrumb
-          if (filterUrl && url.includes(filterUrl)) {
+          if (filterUrl && url.indexOf(filterUrl) !== -1) {
             if (method === 'POST' && args[1] && args[1].body) {
               addSentryBreadcrumb(args[1].body);
             }
@@ -407,7 +407,7 @@ export class Breadcrumbs implements Integration {
             const filterUrl = new API(dsn).getStoreEndpoint();
             // if Sentry key appears in URL, don't capture it as a request
             // but rather as our own 'sentry' type breadcrumb
-            if (isString(url) && (filterUrl && url.includes(filterUrl))) {
+            if (isString(url) && (filterUrl && url.indexOf(filterUrl) !== -1)) {
               this.__sentry_own_request__ = true;
             }
           }

packages/browser/src/parsers.ts

@@ -80,12 +80,12 @@ export function prepareFramesForEvent(stack: TraceKitStackFrame[]): StackFrame[]
   const lastFrameFunction = localStack[localStack.length - 1].func || '';
 
   // If stack starts with one of our API calls, remove it (starts, meaning it's the top of the stack - aka last call)
-  if (firstFrameFunction.includes('captureMessage') || firstFrameFunction.includes('captureException')) {
+  if (firstFrameFunction.indexOf('captureMessage') !== -1 || firstFrameFunction.indexOf('captureException') !== -1) {
     localStack = localStack.slice(1);
   }
 
   // If stack ends with one of our internal API calls, remove it (ends, meaning it's the bottom of the stack - aka top-most call)
-  if (lastFrameFunction.includes('sentryWrapped')) {
+  if (lastFrameFunction.indexOf('sentryWrapped') !== -1) {
     localStack = localStack.slice(0, -1);
   }
 

packages/browser/src/tracekit.ts

@@ -918,10 +918,6 @@ TraceKit._computeStackTrace = (function _computeStackTraceWrapper() {
   }
 
   function popFrames(stacktrace: any, popSize: number): any {
-    if (Number.isNaN(popSize)) {
-      return stacktrace;
-    }
-
     try {
       return {
         ...stacktrace,

packages/browser/test/integration/run.js

@@ -75,9 +75,6 @@ function build() {
     "polyfills/fetch.js",
     "polyfills/raf.js",
     "polyfills/events.js",
-    "polyfills/assign.js",
-    "polyfills/nan.js",
-    "polyfills/includes.js",
   ]);
 
   writeFile(

packages/core/src/dsn.ts

@@ -56,19 +56,22 @@ export class Dsn implements DsnComponents {
   /** Parses a string into this Dsn. */
   private _fromString(str: string): void {
     const match = DSN_REGEX.exec(str);
+
     if (!match) {
       throw new SentryError(ERROR_MESSAGE);
     }
 
     const [protocol, user, pass = '', host, port = '', lastPath] = match.slice(1);
     let path = '';
     let projectId = lastPath;
+
     const split = projectId.split('/');
     if (split.length > 1) {
       path = split.slice(0, -1).join('/');
       projectId = split.pop() as string;
     }
-    Object.assign(this, { host, pass, path, projectId, port, protocol, user });
+
+    this._fromComponents({ host, pass, path, projectId, port, protocol: protocol as DsnProtocol, user });
   }
 
   /** Maps Dsn components into this instance. */
@@ -94,7 +97,7 @@ export class Dsn implements DsnComponents {
       throw new SentryError(ERROR_MESSAGE);
     }
 
-    if (this.port && Number.isNaN(parseInt(this.port, 10))) {
+    if (this.port && isNaN(parseInt(this.port, 10))) {
       throw new SentryError(ERROR_MESSAGE);
     }
   }

packages/hub/src/scope.ts

@@ -224,9 +224,6 @@ export class Scope implements ScopeInterface {
    */
   public static clone(scope?: Scope): Scope {
     const newScope = new Scope();
-    Object.assign(newScope, scope, {
-      _scopeListeners: [],
-    });
     if (scope) {
       newScope._breadcrumbs = [...scope._breadcrumbs];
       newScope._tags = { ...scope._tags };

packages/node/src/integrations/http.ts

@@ -142,7 +142,7 @@ function emitWrapper(origEmit: EventListener): (event: string, response: http.Se
       const dsn = client.getDsn();
 
       const isInterestingEvent = event === 'response' || event === 'error';
-      const isNotSentryRequest = dsn && this.__ravenBreadcrumbUrl && !this.__ravenBreadcrumbUrl.includes(dsn.host);
+      const isNotSentryRequest = dsn && this.__ravenBreadcrumbUrl && this.__ravenBreadcrumbUrl.indexOf(dsn.host) === -1;
 
       if (isInterestingEvent && isNotSentryRequest && getCurrentHub().getIntegration(Http)) {
         getCurrentHub().addBreadcrumb(

packages/node/src/parsers.ts

@@ -157,7 +157,7 @@ export function parseStack(stack: stacktrace.StackFrame[], options?: NodeOptions
     // note that isNative appears to return true even for node core libraries
     // see https://github.com/getsentry/raven-node/issues/176
     parsedFrame.in_app =
-      !isInternal && parsedFrame.filename !== undefined && !parsedFrame.filename.includes('node_modules/');
+      !isInternal && parsedFrame.filename !== undefined && parsedFrame.filename.indexOf('node_modules/') === -1;
 
     // Extract a module name based on the filename
     if (parsedFrame.filename) {
@@ -271,7 +271,7 @@ export function prepareFramesForEvent(stack: StackFrame[]): StackFrame[] {
   let localStack = stack;
   const firstFrameFunction = localStack[0].function || '';
 
-  if (firstFrameFunction.includes('captureMessage') || firstFrameFunction.includes('captureException')) {
+  if (firstFrameFunction.indexOf('captureMessage') !== -1 || firstFrameFunction.indexOf('captureException') !== -1) {
     localStack = localStack.slice(1);
   }
 

packages/utils/src/object.ts

@@ -181,7 +181,8 @@ function normalizeValue<T>(value: T, key?: any): T | string {
     return '[SyntheticEvent]';
   }
 
-  if (Number.isNaN((value as unknown) as number)) {
+  // tslint:disable-next-line:no-tautology-expression
+  if (typeof value === 'number' && value !== value) {
     return '[NaN]';
   }
 

packages/utils/src/string.ts

@@ -117,7 +117,7 @@ export function isMatchingPattern(value: string, pattern: RegExp | string): bool
     return (pattern as RegExp).test(value);
   }
   if (typeof pattern === 'string') {
-    return value.includes(pattern);
+    return value.indexOf(pattern) !== -1;
   }
   return false;
 }