Polyfills Bailout: Part 1 #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
commented
Sep 16, 2019
| @@ -918,10 +918,6 @@ TraceKit._computeStackTrace = (function _computeStackTraceWrapper() { | |||
| } | |||
|
|
|||
| function popFrames(stacktrace: any, popSize: number): any { | |||
| if (Number.isNaN(popSize)) { | |||
There was a problem hiding this comment.
Done on purpose. It's safe to remove.
kamilogorek
commented
Sep 16, 2019
| @@ -224,9 +224,6 @@ export class Scope implements ScopeInterface { | |||
| */ | |||
| public static clone(scope?: Scope): Scope { | |||
| const newScope = new Scope(); | |||
| Object.assign(newScope, scope, { | |||
There was a problem hiding this comment.
I have no clue why we had it here if we manually assign all the properties below anyway.
Same goes for _scopeListeners, which is initialized in the constructor and we don't have to override it if we skip Object.assign.
kamilogorek
force-pushed
the
polyfills-bailout
branch
from
dd04bf4 to
5b0c253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.