POTEL 39 - Use RECORD_ONLY sampling decision if performance is disabled #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
Performance metrics 🚀
|
lbloder
requested changes
Sep 2, 2024
| // TODO [POTEL] should this return RECORD_ONLY to allow tracing without performance | ||
| return SamplingResult.create(SamplingDecision.DROP); | ||
| if (!scopes.getOptions().isTracingEnabled()) { | ||
| System.out.println("not trace sampling -> RECORD_ONLY " + traceId); |
There was a problem hiding this comment.
Console print can be removed
adinauer
deleted the
feat/potel-39-record-only-if-performance-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Also fixes a bug where
isTraceSamplingwas used instead ofisTracingEnabled.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps