Skip to content

Commit

Permalink
Merge fb6f005 into 5583fa5
Browse files Browse the repository at this point in the history
  • Loading branch information
adinauer authored Aug 27, 2024
2 parents 5583fa5 + fb6f005 commit e74261b
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ public SamplingResult shouldSample(

private @NotNull SamplingResult handleRootOtelSpan(
final @NotNull String traceId, final @NotNull Context parentContext) {
if (!scopes.getOptions().isTraceSampling()) {
// TODO [POTEL] should this return RECORD_ONLY to allow tracing without performance
return SamplingResult.create(SamplingDecision.DROP);
if (!scopes.getOptions().isTracingEnabled()) {
System.out.println("not trace sampling -> RECORD_ONLY " + traceId);
return SamplingResult.create(SamplingDecision.RECORD_ONLY);
}
@Nullable Baggage baggage = null;
@Nullable
Expand Down

0 comments on commit e74261b

Please sign in to comment.