-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Convert constants SentrySpanOperations to Swift #4718
Conversation
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3478fc5 | 1237.94 ms | 1251.13 ms | 13.19 ms |
16d73bf | 1200.12 ms | 1221.10 ms | 20.98 ms |
39b1c35 | 1236.35 ms | 1239.90 ms | 3.55 ms |
6bc31df | 1202.52 ms | 1215.86 ms | 13.34 ms |
f587451 | 1271.63 ms | 1275.90 ms | 4.27 ms |
af1f4dd | 1225.39 ms | 1245.48 ms | 20.09 ms |
fdb003d | 1214.51 ms | 1230.49 ms | 15.98 ms |
98752f3 | 1240.61 ms | 1259.80 ms | 19.18 ms |
e072ad1 | 1241.17 ms | 1256.65 ms | 15.48 ms |
aad68bb | 1221.12 ms | 1237.41 ms | 16.29 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3478fc5 | 21.58 KiB | 654.59 KiB | 633.01 KiB |
16d73bf | 21.58 KiB | 669.90 KiB | 648.32 KiB |
39b1c35 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
6bc31df | 21.58 KiB | 544.86 KiB | 523.28 KiB |
f587451 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
fdb003d | 22.85 KiB | 414.11 KiB | 391.26 KiB |
98752f3 | 20.76 KiB | 435.09 KiB | 414.33 KiB |
e072ad1 | 21.58 KiB | 625.83 KiB | 604.24 KiB |
aad68bb | 21.58 KiB | 542.38 KiB | 520.80 KiB |
Previous results on branch: philprime/refactor-span-operations
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5b4c600 | 1226.88 ms | 1244.53 ms | 17.66 ms |
b3783b2 | 1226.64 ms | 1243.39 ms | 16.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5b4c600 | 22.31 KiB | 773.84 KiB | 751.53 KiB |
b3783b2 | 22.31 KiB | 770.49 KiB | 748.17 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4718 +/- ##
=========================================
Coverage 91.204% 91.205%
=========================================
Files 621 622 +1
Lines 72392 72428 +36
Branches 26369 26390 +21
=========================================
+ Hits 66025 66058 +33
- Misses 6267 6272 +5
+ Partials 100 98 -2
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the constants internal if possible.
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Collects all global constants defined in SentrySpanOperations.h and other various variables into static constants in a Swift class
💡 Motivation and Context
💚 How did you test it?
CI tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps