-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add NSNull handling to sentry_sanitize #4760
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
=============================================
+ Coverage 91.077% 91.220% +0.142%
=============================================
Files 622 625 +3
Lines 72360 72654 +294
Branches 25643 26459 +816
=============================================
+ Hits 65904 66275 +371
+ Misses 6362 6281 -81
- Partials 94 98 +4
... and 48 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
077e940 | 1218.33 ms | 1243.24 ms | 24.92 ms |
f1ed6f8 | 1210.94 ms | 1230.78 ms | 19.84 ms |
1f9387b | 1229.25 ms | 1242.62 ms | 13.37 ms |
35647ef | 1250.42 ms | 1251.87 ms | 1.46 ms |
b9a9ffd | 1221.18 ms | 1235.37 ms | 14.19 ms |
0001a09 | 1223.90 ms | 1249.56 ms | 25.66 ms |
add9550 | 1221.20 ms | 1250.04 ms | 28.84 ms |
c0b4b71 | 1246.98 ms | 1256.77 ms | 9.79 ms |
061c982 | 1226.33 ms | 1243.65 ms | 17.33 ms |
86e9bf2 | 1225.70 ms | 1252.19 ms | 26.49 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
077e940 | 21.58 KiB | 706.97 KiB | 685.39 KiB |
f1ed6f8 | 21.58 KiB | 683.51 KiB | 661.93 KiB |
1f9387b | 21.58 KiB | 654.26 KiB | 632.68 KiB |
35647ef | 21.58 KiB | 706.97 KiB | 685.39 KiB |
b9a9ffd | 21.58 KiB | 418.43 KiB | 396.85 KiB |
0001a09 | 20.76 KiB | 433.19 KiB | 412.43 KiB |
add9550 | 21.58 KiB | 418.37 KiB | 396.79 KiB |
c0b4b71 | 20.76 KiB | 430.98 KiB | 410.22 KiB |
061c982 | 21.58 KiB | 683.51 KiB | 661.93 KiB |
86e9bf2 | 22.31 KiB | 758.78 KiB | 736.47 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all the tests for this function!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when the tests are included in Xcode.
Tests/SentryTests/Categories/SentryNSDictionarySanitizeTests.swift
Outdated
Show resolved
Hide resolved
…wift Co-authored-by: Philipp Hofmann <[email protected]>
📜 Description
[NSNull null]
as parameter forsentry_sanitize
sentry_sanitize
💡 Motivation and Context
Closes #4748
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps
none