-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable File I/O APM by default #2497
Conversation
Are there any docs that need to be updated? |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Enable File I/O APM by default ([#2497](https://github.com/getsentry/sentry-cocoa/pull/2497)) If none of the above apply, you can opt out of this check by adding |
CHANGELOG.md
Outdated
@@ -7,6 +7,7 @@ This version adds a dependency on Swift. | |||
### Features | |||
|
|||
- Properly demangle Swift class name (#2162) | |||
- Enable File I/O APM per default (#2497) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry seems to be part of an already released section ## 8.0.0
Uhm what?
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9e77dc | 1231.94 ms | 1254.85 ms | 22.91 ms |
010583c | 1198.23 ms | 1225.52 ms | 27.29 ms |
88ac2c2 | 1223.04 ms | 1243.12 ms | 20.08 ms |
bbe81cb | 1257.25 ms | 1272.24 ms | 14.99 ms |
57e140e | 1223.94 ms | 1252.50 ms | 28.56 ms |
6ef7dc2 | 1204.14 ms | 1253.76 ms | 49.62 ms |
323cdfe | 1263.20 ms | 1272.14 ms | 8.94 ms |
5ed4bee | 1226.02 ms | 1247.50 ms | 21.48 ms |
3936dd2 | 1214.98 ms | 1242.24 ms | 27.26 ms |
d446105 | 1237.06 ms | 1261.34 ms | 24.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9e77dc | 20.75 KiB | 379.12 KiB | 358.36 KiB |
010583c | 20.75 KiB | 383.61 KiB | 362.85 KiB |
88ac2c2 | 20.75 KiB | 373.61 KiB | 352.86 KiB |
bbe81cb | 20.75 KiB | 381.81 KiB | 361.06 KiB |
57e140e | 20.75 KiB | 383.61 KiB | 362.85 KiB |
6ef7dc2 | 20.75 KiB | 383.39 KiB | 362.64 KiB |
323cdfe | 20.75 KiB | 383.50 KiB | 362.75 KiB |
5ed4bee | 20.75 KiB | 404.63 KiB | 383.88 KiB |
3936dd2 | 20.75 KiB | 383.29 KiB | 362.53 KiB |
d446105 | 20.75 KiB | 383.37 KiB | 362.62 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2497 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 242 242
Lines 22416 22431 +15
Branches 9187 9189 +2
=====================================
- Misses 22411 22426 +15
Partials 5 5
Continue to review full report at Codecov.
|
Yes, but we do that once 8.0.0 is GA. We will batch that together in one bigger PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m
: Please also update the code docs
sentry-cocoa/Sources/Sentry/Public/SentryOptions.h
Lines 261 to 265 in fded9f8
/** | |
* When enabled, the SDK tracks performance for file IO reads and writes with NSData if auto | |
* performance tracking and enableSwizzling are enabled. The default is <code>NO</code>. | |
*/ | |
@property (nonatomic, assign) BOOL enableFileIOTracing; |
LGTM
📜 Description
See title.
💡 Motivation and Context
Closes #2264.
💚 How did you test it?
Unit test.
📝 Checklist
🔮 Next steps