-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update homebrew bundle #2495
Conversation
This didn't result in any code formatting changes, but that's because the format code step didn't even run. I guess I have to change at least one ObjC or Swift file? |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9e77dc | 1231.94 ms | 1254.85 ms | 22.91 ms |
010583c | 1198.23 ms | 1225.52 ms | 27.29 ms |
88ac2c2 | 1223.04 ms | 1243.12 ms | 20.08 ms |
bbe81cb | 1257.25 ms | 1272.24 ms | 14.99 ms |
57e140e | 1223.94 ms | 1252.50 ms | 28.56 ms |
6ef7dc2 | 1204.14 ms | 1253.76 ms | 49.62 ms |
323cdfe | 1263.20 ms | 1272.14 ms | 8.94 ms |
5ed4bee | 1226.02 ms | 1247.50 ms | 21.48 ms |
3936dd2 | 1214.98 ms | 1242.24 ms | 27.26 ms |
d446105 | 1237.06 ms | 1261.34 ms | 24.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9e77dc | 20.75 KiB | 379.12 KiB | 358.36 KiB |
010583c | 20.75 KiB | 383.61 KiB | 362.85 KiB |
88ac2c2 | 20.75 KiB | 373.61 KiB | 352.86 KiB |
bbe81cb | 20.75 KiB | 381.81 KiB | 361.06 KiB |
57e140e | 20.75 KiB | 383.61 KiB | 362.85 KiB |
6ef7dc2 | 20.75 KiB | 383.39 KiB | 362.64 KiB |
323cdfe | 20.75 KiB | 383.50 KiB | 362.75 KiB |
5ed4bee | 20.75 KiB | 404.63 KiB | 383.88 KiB |
3936dd2 | 20.75 KiB | 383.29 KiB | 362.53 KiB |
d446105 | 20.75 KiB | 383.37 KiB | 362.62 KiB |
Previous results on branch: chore/brew-bundle
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b77f733 | 1199.69 ms | 1237.36 ms | 37.67 ms |
32de5c7 | 1234.02 ms | 1270.42 ms | 36.40 ms |
ed0af7d | 1276.16 ms | 1287.91 ms | 11.75 ms |
5efbb4e | 1220.26 ms | 1239.06 ms | 18.80 ms |
16e1f84 | 1229.57 ms | 1248.18 ms | 18.61 ms |
125dc16 | 1212.66 ms | 1230.42 ms | 17.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b77f733 | 20.75 KiB | 404.63 KiB | 383.88 KiB |
32de5c7 | 20.75 KiB | 404.64 KiB | 383.88 KiB |
ed0af7d | 20.75 KiB | 404.63 KiB | 383.88 KiB |
5efbb4e | 20.75 KiB | 404.84 KiB | 384.08 KiB |
16e1f84 | 20.75 KiB | 404.84 KiB | 384.08 KiB |
125dc16 | 20.75 KiB | 404.84 KiB | 384.08 KiB |
Damnit, CI is still overwriting the formatting that was done locally. How do we fix this? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2495 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 242 242
Lines 22416 22431 +15
Branches 9187 9189 +2
=====================================
- Misses 22411 22426 +15
Partials 5 5
Continue to review full report at Codecov.
|
After updating on which macOS version it runs, CI is now also using SwiftLint 0.50.1, and local changes are no longer overwritten by CI 🎉 |
I am running a different version of SwiftLint locally, and CI is running an old version, which causes code formatting mismatches, so CI keeps overwriting the code formatting again. See the commit history in #2489.
Not sure if this is the correct way to fix it? Let's see.
#skip-changelog