Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag stichAsyncCode #1172

Merged
merged 8 commits into from
Jun 18, 2021
Merged

feat: Add flag stichAsyncCode #1172

merged 8 commits into from
Jun 18, 2021

Conversation

philipphofmann
Copy link
Member

📜 Description

Add stichAsyncCode to SentryOptions to be able to enable stitching stack traces
of async code together.

💡 Motivation and Context

Fixes GH-1086

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Add stichAsyncCode to SentryOptions to be able to enable stitching stack traces
of async code together.

Fixes GH-1086
@philipphofmann philipphofmann requested a review from a team June 16, 2021 08:33
@github-actions
Copy link

github-actions bot commented Jun 16, 2021

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 568f708

philipphofmann and others added 5 commits June 17, 2021 09:12
Since Carthage 0.38.0 we can support XCFrameworks by creating separate
.framework.zip and .xcframework.zip archives.

Fixes GH-945
Separated the UIPerformanceTracker behaviour from swizzling.

Co-authored-by: Sentry Github Bot <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Philipp Hofmann <[email protected]>
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann enabled auto-merge (squash) June 18, 2021 12:27
@philipphofmann philipphofmann merged commit 570212d into master Jun 18, 2021
@philipphofmann philipphofmann deleted the feat/stitch-async-code branch June 18, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag for Async Stacktrace on SentryOptions
3 participants