Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag for Async Stacktrace on SentryOptions #1086

Closed
philipphofmann opened this issue Apr 27, 2021 · 1 comment · Fixed by #1172
Closed

Flag for Async Stacktrace on SentryOptions #1086

philipphofmann opened this issue Apr 27, 2021 · 1 comment · Fixed by #1172
Assignees
@philipphofmann
Labels
Type: Enhancement

Comments

@philipphofmann
Copy link
Member

Provide a flag on SentryOptions to enable and disable async stack traces, added in #998. Explain in the code docs that this feature is not 100% stable yet, might impact the application's performance, and impact grouping.
philipphofmann added a commit that referenced this issue Apr 27, 2021
@philipphofmann
ref: Disable Async Stacktraces
f4fa940 
Due to some problems with arm64 devices, we disable this feature until we find out how to fix them.
We don't want this feature to block 7.0.0 GA. The plan is to add a flag to SentryOptions for enabling
and disabling this feature in the future, see #1086.
philipphofmann added a commit that referenced this issue Apr 27, 2021
@philipphofmann
ref: Disable Async Stacktraces
501fa3b 
Due to some problems with arm64 devices, we disable this feature until we find out how to fix them.
We don't want this feature to block 7.0.0 GA. The plan is to add a flag to SentryOptions for enabling
and disabling this feature in the future, see #1086.
@philipphofmann philipphofmann mentioned this issue Apr 27, 2021
Merged
6 tasks
philipphofmann added a commit that referenced this issue Apr 27, 2021
@philipphofmann
ref: Disable Async Stacktraces (#1087)
0be5c01 
Due to some problems with arm64 devices, we disable this feature until we find out how to fix them.
We don't want this feature to block 7.0.0 GA. The plan is to add a flag to SentryOptions for enabling
and disabling this feature in the future, see #1086.
@bruno-garcia
Copy link
Member

bruno-garcia commented May 12, 2021 •
edited
Loading

Agreed to be an opt-in for now, with a disclaimer that affects grouping.
We'll validate the feature and get customer feedback and potentially having it as an opt-out on the next major.

We discussed the name enableAsyncStackTraces is a best effort at this point because it doesn't really communicate what the feature does. So name is up to be improved.

philipphofmann added a commit that referenced this issue Jun 16, 2021
@philipphofmann
feat: Add flag stichAsyncCode
32e1eeb 
Add stichAsyncCode to SentryOptions to be able to enable stitching stack traces
of async code together.

Fixes GH-1086
@philipphofmann philipphofmann mentioned this issue Jun 16, 2021
Merged
5 tasks
@philipphofmann philipphofmann self-assigned this Jun 16, 2021
philipphofmann added a commit that referenced this issue Jun 18, 2021
@philipphofmann
feat: Add flag stichAsyncCode (#1172)
570212d 
Add stichAsyncCode to SentryOptions to be able to enable stitching stack traces
of async code together.

Fixes GH-1086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add flag stichAsyncCode getsentry/sentry-cocoa
2 participants
@bruno-garcia @philipphofmann