-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official crates.io release #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a706ff5
to
f447325
Compare
- This removes the `out-refs` feature (now always bundled). - This removes the `csharp-headers` feature (now part of `headers`).
2 tasks
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the long-living
master
branch ofsafer-ffi
finally releasable to crates.io again.To become a
0.1.0-rc1
release; a proper release may follow later.Despite the
0.1.0
, future releases will probably be breaking anyways (0.2.0
, etc.), since between the header generation (sensitive to name "mangling" schemes), the module naming, etc., it would be way too limiting for me to already try to aim for semver-compatible releases. I will, however, strive to make these breaking changes be soft / easy to tackle.Notes
The
js
support is still deemed too experimental to be made public (most users should just stick to using#[wasm_bindgen]
or#[napi]
directly), so it is not part of the crates.io package (in practice this is achieved by shadowing it with a::cratesio-placeholder-package
).C# "header" generation, on the other hand, is made public, even though it supports fewer features than C header generation (e.g., no pointers to a
fn
pointer), due to .NET being such a non-system programming language for certain things.repr_c::Box<[T]>
now magically stands for the less ergonomicc_slice::Box<T>
, hopefully improving the readability of function signatures.repr_c::Box::new()
due to type inference and function resolution, sincerepr_c::Box
is currently implemented as a meretype
alias. I may use a dedicated newtype/tuplestruct
if this is deemed too unergonomic.Box::new(…).into()
is to be used instead.dyn Trait
support! 🚀And a bunch of other things I may be forgetting.