Remove extern crates from napi-dispatcher #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiemort
force-pushed
the
sm/unused-extern-crate
branch
from
c160d29 to
f2119c4
Compare
|
Yeah, I'm tempted to say it should be fine, but since Cargo can get confused with renames (it's an are where it's incredibly brittle / not up to the standards of a mature feature), I'll have to try it against a codebase extensively using the |
|
Fixed in #155 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denying
rust_2018_idiomsflags theextern crate napi;as unused - and if I'm understanding Rust 2018 correctly, both of these can be removed because thepub extern cratecan be turned into a re-export.Am I off-base here? I don't think this should break anything.