Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup! added point.x_mut() and point.y_mut() #909

Merged
merged 1 commit into from
Sep 17, 2022
Merged

fixup! added point.x_mut() and point.y_mut() #909

merged 1 commit into from
Sep 17, 2022

Conversation

michaelkirk
Copy link
Member

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

The changelog was correct, but it didn't coincide with the actual method implementations which were not named according to convention.

This hasn't been released yet, so it's not considered a breaking change.

Followup to #899

The changelog was correct, but the methods were not named according to
convention.

This hasn't been released yet, so it's not considered a breaking change.
@rmanoka
Copy link
Contributor

rmanoka commented Sep 15, 2022

Wouldn't it be nicer to instead of Deref and DerefMut to Coordinate instead? We might need a repr transparent on Point, but seems fair to add it.

@rmanoka
Copy link
Contributor

rmanoka commented Sep 15, 2022

The CI failure seems to be from arbitrary crate's min-rust requirement I think.

@frewsxcv
Copy link
Member

My vote would be to merge this, and then have a separate discussion about adding a Deref impl for Point to Coordinate. There are some people in the Rust community who think Deref should be reserved for pointer types, so it could warrant a little discussion.

@michaelkirk
Copy link
Member Author

bors r=lnicola

I'm gonna go ahead and merge this (I think CI will succeed now that #910).

I'm happy to talk about Deref, though I gotta tell you, lately I've been thinking we should just resurrect #15.

@bors
Copy link
Contributor

bors bot commented Sep 17, 2022

Build succeeded:

@bors bors bot merged commit a45086f into main Sep 17, 2022
@bors bors bot deleted the mkirk/rename-mut branch September 17, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants