point.x_mut() and point.y_mut() #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
approved these changes
Aug 29, 2022
|
Build succeeded: |
2 tasks
bors bot
added a commit
that referenced
this pull request
Sep 17, 2022
909: fixup! added point.x_mut() and point.y_mut() r=lnicola a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- The changelog was correct, but it didn't coincide with the actual method implementations which were not named according to convention. This hasn't been released yet, so it's not considered a breaking change. Followup to #899 Co-authored-by: Michael Kirk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.I added methods point.x_mut() and point.y_mut() as described in the issue #898. This is my first PR, I read the code of conduct and contribution guidelines but may have missed something, I'd be happy to hear about what I can do better