dev-python/pyBigWig: version bump 0.3.24, add tests, remove outdated ebuilds #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebuilds Signed-off-by: Michael Schubert <[email protected]>
mschubert
commented
Jan 29, 2025
Comment on lines
+29
to
+31
| ln -s "${S}"/pyBigWigTest/test.bigBed "${pysite}"/pyBigWigTest || die | ||
| ln -s "${S}"/pyBigWigTest/test.bw "${pysite}"/pyBigWigTest || die | ||
| epytest pyBigWigTest/test.py |
There was a problem hiding this comment.
I'm not sure if there is a better way than linking
There was a problem hiding this comment.
What about setting PYTHONPATH?
There was a problem hiding this comment.
The problem here is that:
- The test accesses the file using
os.path.dirname(pyBigWig.__file__) + "/pyBigWigTest/test.bigBed" pyBigWigonly exists as.sofile in the build directory (without those files)- Setting
PYTHONPATHdoesn't change the file path construction of the former
There was a problem hiding this comment.
DISTUTILS_IN_SOURCE_BUILD=1 might help here.
There was a problem hiding this comment.
I'm getting: DISTUTILS_IN_SOURCE_BUILD is not supported in PEP517 mode
There was a problem hiding this comment.
Right, let's just keep it as it is then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for deeptools PR