Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

PDF export: Add warning that feature is beta #923

Merged
merged 7 commits into from
Oct 29, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Unit-specific comments. [#761](https://github.com/geli-lms/geli/issues/761)
- Simple E2E test for login. [#795](https://github.com/geli-lms/geli/pull/795)
- Checkboxes for accepting our terms of use and privacy declarations while registering. [#778](https://github.com/geli-lms/geli/issues/778)
- PDF course content download functionality. [#720](https://github.com/geli-lms/geli/pull/720)
- PDF course content download functionality. [#720](https://github.com/geli-lms/geli/pull/720), [#923](https://github.com/geli-lms/geli/pull/923)
- User data deletion functionality for EU-GDPR compliance. [#775](https://github.com/geli-lms/geli/issues/775)
- Personal data export functionality for EU-GDPR compliance. [#805](https://github.com/geli-lms/geli/issues/805)
- Guided dialog for adding a whitelist. [#727](https://github.com/geli-lms/geli/issues/727) [#509](https://github.com/geli-lms/geli/issues/509)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class CourseDetailComponent implements OnInit, OnDestroy {
this.tabs = [{path: 'overview', label: t['common.content'], img: 'school'},
{path: 'fileview', label: t['common.documents'], img: 'insert_drive_file'},
{path: 'videoview', label: t['common.videos'], img: 'video_library'},
{path: 'download', label: t['common.download'], img: 'get_app'}];
{path: 'download', label: t['common.download'] + ' (Beta)', img: 'get_app'}];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate if 'Beta' is in the languages File. Or do you have a special reason to put this at this point here?

});
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
<div *ngIf="this.checkForEmptyLectures()">
<mat-card class="dl-card">
<mat-card-content>
<p class="beta-warning">
Heads up! The download feature is still in development.
We assume that for most lectures the export works quite well but there are some corner cases where the export might not work as you expect.
If you find a mistake please report it back to <a href="https://github.com/geli-lms/geli/issues" target="_blank">https://github.com/geli-lms/geli/issues</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielkesselberg Would put this inside the translations files

</p>
</mat-card-content>
<mat-card-content>
<ng-container *ngIf="!this.checkForEmptyLectures()">{{'common.text.downloadNoFiles' | translate}}</ng-container>
<mat-list>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,8 @@
.radio-buttons .radio-button:nth-child(n+2){
margin-left: 20px;
}

.beta-warning {
color: red;
font-weight: bolder;
}