This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
PDF export: Add warning that feature is beta #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
added
web-frontend
kesselb
requested review from
dboschm,
Gargamil,
lukas-schardt,
MichaelNarkus and
torss
kesselb
changed the title
| <p class="beta-warning"> | ||
| Heads up! The download feature is still in development. | ||
| We assume that for most lectures the export works quite well but there are some corner cases where the export might not work as you expect. | ||
| If you find a mistake please report it back to <a href="https://github.com/geli-lms/geli/issues" target="_blank">https://github.com/geli-lms/geli/issues</a> |
There was a problem hiding this comment.
@danielkesselberg Would put this inside the translations files
Gargamil
reviewed
Oct 29, 2018
| @@ -56,7 +56,7 @@ export class CourseDetailComponent implements OnInit, OnDestroy { | |||
| this.tabs = [{path: 'overview', label: t['common.content'], img: 'school'}, | |||
| {path: 'fileview', label: t['common.documents'], img: 'insert_drive_file'}, | |||
| {path: 'videoview', label: t['common.videos'], img: 'video_library'}, | |||
| {path: 'download', label: t['common.download'], img: 'get_app'}]; | |||
| {path: 'download', label: t['common.download'] + ' (Beta)', img: 'get_app'}]; | |||
There was a problem hiding this comment.
Would appreciate if 'Beta' is in the languages File. Or do you have a special reason to put this at this point here?
Gargamil
suggested changes
Oct 29, 2018
Gargamil
approved these changes
Oct 29, 2018
Gargamil
approved these changes
Oct 29, 2018
kesselb
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ref #913
Improvements