Skip to content

ci: remove check_todos.yml. #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tm91236
Copy link
Member

@tm91236 tm91236 commented Apr 9, 2025

PR Type

  • CI related changes

Description

Replace the functionality provided in check_todos.yml with the pre_commit_checks.yml workflow, by adding 'TD' to the ruff rule selections, and ignoring 'TD002', in the pyproject.toml.

This has the additional benefit of informing users of the CI expectations in pre-commit.

How Has This Been Tested?

N/A

Does this PR introduce a breaking change?

N/A

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

Replace the functionality provided in `check_todos.yml` with the
`pre_commit_checks.yml` workflow, by adding 'TD' to the ruff rule
selections, and ignoring 'TD002', in the `pyproject.toml`.

This has the additional benefit of informing users of the CI
expectations in pre-commit.
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Performance review

Commit 7958b62 - Merge d411323 into cd059c5

No significant changes to performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant