Skip to content

Commit d411323

Browse files
committed
ci: remove check_todos.yml.
Replace the functionality provided in `check_todos.yml` with the `pre_commit_checks.yml` workflow, by adding 'TD' to the ruff rule selections, and ignoring 'TD002', in the `pyproject.toml`. This has the additional benefit of informing users of the CI expectations in pre-commit.
1 parent 94fc03c commit d411323

File tree

2 files changed

+10
-33
lines changed

2 files changed

+10
-33
lines changed

.github/workflows/check_todos.yml

-25
This file was deleted.

pyproject.toml

+10-8
Original file line numberDiff line numberDiff line change
@@ -148,24 +148,26 @@ select = [
148148
"PL", # pylint
149149
"S102", # exec-builtin
150150
"S307", # suspicious-eval-usage
151+
"TD", # flake8-todo
151152
"UP", # pyupgrade
152153
"W", # pycodestyle [warning]
153154
]
154155

155156
ignore = [
156157
# Incompatible with ruff format
157-
"D206", # indent-with-spaces
158-
"E111", # indentation-with-invalid-multiple
159-
"E114", # indentation-with-invalid-multiple-comment
160-
"E117", # over-indented
161-
"W191", # tab-indentation
158+
"D206", # indent-with-spaces
159+
"E111", # indentation-with-invalid-multiple
160+
"E114", # indentation-with-invalid-multiple-comment
161+
"E117", # over-indented
162+
"W191", # tab-indentation
162163
# Incompatible with other pydocstyle rules
163-
"D203", # one-blank-line-before-class
164-
"D212", # multi-line-summary-first-line
164+
"D203", # one-blank-line-before-class
165+
"D212", # multi-line-summary-first-line
165166
# Incompatible with jaxtyping
166-
"F722", # forward-annotation-syntax-error
167+
"F722", # forward-annotation-syntax-error
167168
# Opinionated ignores
168169
"PLR6301", # no-self-use (opinionated)
170+
"TD002", # missing-todo-author (opinionated)
169171
]
170172

171173
[tool.ruff.lint.per-file-ignores]

0 commit comments

Comments
 (0)