Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sensor metrics on example worlds #982

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 19, 2021

🎉 New feature

Requires gazebosim/gz-sensors#146

Summary

Enable the new sensor metrics for the example worlds to give the feature more visibility.

Test it

For example:

ign gazebo -r src/ign-gazebo/examples/worlds/sensors_demo.sdf 

And on another terminal you can check the performance metrics topics:

$ ign topic -l | grep performance
/camera_alone/performance_metrics
/depth_camera/performance_metrics
/lidar/points/performance_metrics
/rgbd_camera/performance_metrics

And echo one of them:

$ ign topic -e -t /camera_alone/performance_metrics
...
name: "cameras_alone::link::cameras_alone"
real_update_rate: 30.017970558254408
sim_update_rate: 30.303030303032418
nominal_update_rate: 30
...

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Aug 19, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 19, 2021
Signed-off-by: Louise Poubel <[email protected]>
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chapulina chapulina mentioned this pull request Aug 26, 2021
7 tasks
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Aug 27, 2021
@chapulina
Copy link
Contributor Author

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #982 (1f5a207) into ign-gazebo3 (c625586) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #982      +/-   ##
===============================================
+ Coverage        77.79%   77.84%   +0.04%     
===============================================
  Files              221      221              
  Lines            12687    12687              
===============================================
+ Hits              9870     9876       +6     
+ Misses            2817     2811       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 94.49% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c625586...1f5a207. Read the comment docs.

@chapulina chapulina merged commit aede69c into ign-gazebo3 Aug 31, 2021
@chapulina chapulina deleted the chapulina/3/enable_metrics branch August 31, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants