Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable focal and attempt to use tooling images #503

Closed
wants to merge 11 commits into from

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Dec 18, 2020

Re-enable continuous integration on focal.

This also makes use the docker container actions that are set up here: https://github.com/ignition-tooling/setup-ign-docker

Those containers pre-install all of the dependencies found in a particular collection, which should accelerate CI a little bit.

Signed-off-by: Michael Carroll [email protected]

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 18, 2020
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll marked this pull request as ready for review January 7, 2021 23:01
@mjcarroll mjcarroll requested a review from chapulina as a code owner January 7, 2021 23:01
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #503 (bb4c10d) into ign-gazebo4 (302f5ed) will decrease coverage by 11.71%.
The diff coverage is 68.76%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo4     #503       +/-   ##
================================================
- Coverage        77.37%   65.65%   -11.72%     
================================================
  Files              217      240       +23     
  Lines            12217    17824     +5607     
================================================
+ Hits              9453    11703     +2250     
- Misses            2764     6121     +3357     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/rendering/SceneManager.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 7.29% <0.00%> (-1.32%) ⬇️
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
src/gui/plugins/entity_tree/EntityTree.cc 9.83% <0.00%> (-0.06%) ⬇️
src/network/PeerTracker.hh 100.00% <ø> (ø)
src/systems/apply_joint_force/ApplyJointForce.hh 100.00% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh 100.00% <ø> (ø)
src/systems/buoyancy/Buoyancy.hh 100.00% <ø> (ø)
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fe608...bb4c10d. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for remembering that Focal CI needs to be re-enabled! I think that we also need to fix all the Focal warnings / tests.

This also makes use the docker container actions that are set up here: https://github.com/ignition-tooling/setup-ign-docker

Mind adding some information to that repository's README? It's hard to know what it's doing without digging through the code.

One thing I'm wondering about is how often these images are updated. For example, if we made a release 1 hour ago, will it be picked up?

@mjcarroll
Copy link
Contributor Author

mjcarroll commented Jan 8, 2021

Mind adding some information to that repository's README? It's hard to know what it's doing without digging through the code.

Yep! Can do.

Edit: gazebo-tooling/setup-gz-docker#3

One thing I'm wondering about is how often these images are updated. For example, if we made a release 1 hour ago, will it be picked up?

They are currently built hourly. There is a chance that a release could be missed, but it should be picked up in the next build.

Edit: Now that I think about this, because we do an apt update && install in the action itself, it should pull the newest dependencies during that step.

@chapulina chapulina mentioned this pull request Feb 24, 2021
8 tasks
@chapulina
Copy link
Contributor

Regular Focal CI was added in #646 and is being ported forward in #792. Once that's in, this PR can be updated to just use the tooling images (no need to handle the addition of Focal).

Signed-off-by: Louise Poubel <[email protected]>
@@ -7,19 +7,31 @@ jobs:
runs-on: ubuntu-latest
name: Ubuntu Bionic CI
steps:
- name: Login to GitHub Container Registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can skip this step? Can the container be publicly available, or shared with the ignitionrobotics org? This way, we just need to update the action-ignition-ci repository and don't need to add this step to all branches of all libraries.

@mjcarroll mjcarroll closed this Nov 3, 2021
@mjcarroll mjcarroll deleted the use_ign-tooling branch August 1, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants