-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable focal and attempt to use tooling images #503
Conversation
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #503 +/- ##
================================================
- Coverage 77.37% 65.65% -11.72%
================================================
Files 217 240 +23
Lines 12217 17824 +5607
================================================
+ Hits 9453 11703 +2250
- Misses 2764 6121 +3357
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for remembering that Focal CI needs to be re-enabled! I think that we also need to fix all the Focal warnings / tests.
This also makes use the docker container actions that are set up here: https://github.com/ignition-tooling/setup-ign-docker
Mind adding some information to that repository's README? It's hard to know what it's doing without digging through the code.
One thing I'm wondering about is how often these images are updated. For example, if we made a release 1 hour ago, will it be picked up?
Yep! Can do. Edit: gazebo-tooling/setup-gz-docker#3
They are currently built hourly. There is a chance that a release could be missed, but it should be picked up in the next build. Edit: Now that I think about this, because we do an |
Signed-off-by: Louise Poubel <[email protected]>
@@ -7,19 +7,31 @@ jobs: | |||
runs-on: ubuntu-latest | |||
name: Ubuntu Bionic CI | |||
steps: | |||
- name: Login to GitHub Container Registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we can skip this step? Can the container be publicly available, or shared with the ignitionrobotics
org? This way, we just need to update the action-ignition-ci
repository and don't need to add this step to all branches of all libraries.
Re-enable continuous integration on focal.
This also makes use the docker container actions that are set up here: https://github.com/ignition-tooling/setup-ign-docker
Those containers pre-install all of the dependencies found in a particular collection, which should accelerate CI a little bit.
Signed-off-by: Michael Carroll [email protected]