Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable focal and attempt to use tooling images #503

Closed
wants to merge 11 commits into from
Closed

Re-enable focal and attempt to use tooling images #503

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
979d7a6
Re-enable focal and attempt to use tooling images
mjcarroll Dec 18, 2020
a3f1565
Add container registry token
mjcarroll Dec 18, 2020
26e4fcd
Change login mechanism
mjcarroll Dec 18, 2020
d9155b5
Merge branch 'ign-gazebo4' into use_ign-tooling
mjcarroll Jan 7, 2021
b729239
Merge branch 'ign-gazebo4' into use_ign-tooling
mjcarroll Jan 8, 2021
46772d6
Merge branch 'ign-gazebo4' into use_ign-tooling
mjcarroll Jan 11, 2021
b925a37
Merge branch 'ign-gazebo4' into use_ign-tooling
mjcarroll Jan 13, 2021
bc59f71
Merge branch 'ign-gazebo4' into use_ign-tooling
chapulina Feb 11, 2021
5e4eb80
Merge branch 'ign-gazebo4' into use_ign-tooling
chapulina Feb 17, 2021
52e8661
Merge branch 'ign-gazebo4' into use_ign-tooling
chapulina Feb 24, 2021
bb4c10d
merged from ign-gazebo4
chapulina May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,32 @@ jobs:
runs-on: ubuntu-latest
name: Ubuntu Bionic CI
steps:
- name: Login to GitHub Container Registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can skip this step? Can the container be publicly available, or shared with the ignitionrobotics org? This way, we just need to update the action-ignition-ci repository and don't need to add this step to all branches of all libraries.

uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.CR_PAT }}
- name: Checkout
uses: actions/checkout@v2
- name: Compile and test
id: ci
uses: ignition-tooling/action-ignition-ci@master
uses: ignition-tooling/action-ignition-ci@ign-tooling-bionic
with:
codecov-token: ${{ secrets.CODECOV_TOKEN }}
# TODO(anyone) Enable Focal CI and fix failing tests
# focal-ci:
# runs-on: ubuntu-latest
# name: Ubuntu Focal CI
# steps:
# - name: Checkout
# uses: actions/checkout@v2
# - name: Compile and test
# id: ci
# uses: ignition-tooling/action-ignition-ci@focal
focal-ci:
runs-on: ubuntu-latest
name: Ubuntu Focal CI
steps:
- name: Login to GitHub Container Registry
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.CR_PAT }}
- name: Checkout
uses: actions/checkout@v2
- name: Compile and test
id: ci
uses: ignition-tooling/action-ignition-ci@ign-tooling-focal