Use selection buffer in ray queries (ogre2) #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
7 tasks
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #378 +/- ##
==================================================
+ Coverage 55.91% 56.32% +0.40%
==================================================
Files 147 147
Lines 13983 14119 +136
==================================================
+ Hits 7819 7952 +133
- Misses 6164 6167 +3
Continue to review full report at Codecov.
|
This was referenced Aug 19, 2021
ahcorde
requested changes
Aug 19, 2021
|
the |
nkoenig
approved these changes
Sep 14, 2021
* extend selection buffer to return depth Signed-off-by: Ian Chen <[email protected]> * selection buffer depth working Signed-off-by: Ian Chen <[email protected]> * cleanup Signed-off-by: Ian Chen <[email protected]> * style Signed-off-by: Ian Chen <[email protected]> * add check for mac Signed-off-by: Ian Chen <[email protected]> * Add shaders Signed-off-by: Ian Chen <[email protected]> * enable mac test Signed-off-by: Ian Chen <[email protected]> * style Signed-off-by: Ian Chen <[email protected]> * fix bad merge Signed-off-by: Ian Chen <[email protected]> * fix drag and drop Signed-off-by: Ian Chen <[email protected]> * fix utils test Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
9 tasks
iche033
pushed a commit
that referenced
this pull request
Dec 2, 2022
This PR does 3 things: Adds Ogre2LensFlare Adds tests to test this new pass to INTEGRATION_render_pass Works for both normal Camera and WideAngleCamera. Significantly optimizes Ogre2RayQuery The original CPU implementation is ridiculously slow PR Use selection buffer in ray queries (ogre2) #378 used a GPU implementation to address these issues. However the GPU version can't be easily used (without bigger refactors to how gz-rendering operates) because we need to render (for ray queries) while we are about to render (for lens flares). We cannot use the GPU version. This PR adds an option to force CPU method. LensFlare heavily relies on a lot of raycasts for occlusion (depends on the value passed to SetOcclusionSteps). Signed-off-by: Matias N. Goldberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Replaces part of ray query logic with the use of selection buffer (mouse picking) for performance improvement.
The current ray query implementation has 2 stages:
These 2 stages are all done on the CPU and they can be slow if the user clicks on a region with multiple overlapping bounding boxes. This PR replaces stage 1 with the use of selection buffer which can efficiently return the first object that the user clicks on. So that in stage 2 we would only need to do ray intersection test with 1 mesh.
Stage 2 can also be improved. That'll come later. Update: see #383
Test it
Use ign-gazebo, insert multiple overlapping complex meshes, and try panning with the mouse by left clicking on a mesh in the scene and dragging the mouse. The movement should be less laggy with these changes. See gazebosim/gz-sim#969
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge