Add null checks when loading example render engine #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
JShep1
approved these changes
Oct 1, 2020
iche033
added a commit
that referenced
this pull request
Oct 13, 2020
* Add unversioned symlinks for engine plugins Signed-off-by: John Shepherd <[email protected]> * Add init attempt at custom render engine Signed-off-by: John Shepherd <[email protected]> * Refactor Signed-off-by: John Shepherd <[email protected]> * Clean up Signed-off-by: John Shepherd <[email protected]> * Add init attempt Signed-off-by: John Shepherd <[email protected]> * Clean Signed-off-by: John Shepherd <[email protected]> * Add null checks when loading example render engine (#156) Add null checks and docs Signed-off-by: Ian Chen <[email protected]> Co-authored-by: John Shepherd <[email protected]> * Add windows build rules Signed-off-by: John Shepherd <[email protected]> * Take in paths from ign gazebo Signed-off-by: John Shepherd <[email protected]> * Update docs Signed-off-by: John Shepherd <[email protected]> * Add init attempt at rendering plugin tutorial Signed-off-by: John Shepherd <[email protected]> * Requested fixes Signed-off-by: John Shepherd <[email protected]> * minor tweak to heading Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The null checks I added are in BaseRenderEngine.cc