-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Render Plugin Example #154
Conversation
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
The changes here allows the plugin to load in the ign-rendering side. It's now just failing in RenderUtil on the in-gazebo side since there are several places that assume a non-null scene.. |
Can you make the PR? Mainly so I can approve. Also, I made an additional PR for ign-gazebo here adding additional null checks. I found where the seg faults were occurring in |
created pull request #156 containing the null checks, and your changes :) |
Add null checks and docs Signed-off-by: Ian Chen <[email protected]> Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
…_binary_name_support Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
This is ready for a review whenever you have time. @iche033 |
…custom_plugin_example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice it's working for me! I am able load the hello world plugin following the instructions in the README.md. Just some minor style and doc comments
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #154 +/- ##
==================================================
+ Coverage 50.44% 50.48% +0.03%
==================================================
Files 129 129
Lines 11709 11740 +31
==================================================
+ Hits 5907 5927 +20
- Misses 5802 5813 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…/ignitionrobotics/ign-rendering into jshep1/add_custom_plugin_example Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
The last piece to getting the custom render engine issue (#100) resolved.
This example simply adds a mock render engine plugin that the user can load with
--render-engine HelloWorldPlugin
, it won't display anything to the scene as there is actually no implementation, this just serves as a template for any future user desiring to write their own render engine plugin.Signed-off-by: John Shepherd [email protected]
Depends on gazebosim/gz-sim#373