-
Notifications
You must be signed in to change notification settings - Fork 494
[Gazebo9] Fixed fails for OSX: Added using namespace boost::placeholders #2809
Conversation
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
I still see some problems on the Mac build. Are they related to this PR?
|
The compilation of the tests are failing. I'm trying to find a better solution |
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: ahcorde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think an alternative would be to use std::bind
instead of boost::bind
, but this is more concise
Signed-off-by: Louise Poubel <[email protected]>
ah, it looks like the Ubuntu builds are broken by the I think we should either:
|
I'm going to take a quick look at this to see if it's an easy fix |
boost::bind changed its syntax for the placeholders, so just switch to std::bind and add a scoped using namespace std::placeholders to reduce the size of the diff. Signed-off-by: Steve Peters <[email protected]>
I took this approach in 5d3d06e; it's more than 3 lines per file, but it reduces our boost usage slightly without an unwieldy diff |
it doesn't work for ubuntu though 🤭 |
Revert the previous change to std::bind. Signed-off-by: Steve Peters <[email protected]>
I switched to the other approach in fd718ac ( |
thank you @scpeters for rework this PR 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
…ers (#2809) Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]>
…ers (gazebosim#2809) Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]>
…ers (gazebosim#2809) Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]>
…ers (#2809) Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]>
…ers (#2809) Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Use patch from gazebosim/gazebo-classic#2809 Signed-off-by: Steve Peters <[email protected]>
Use patch from gazebosim/gazebo-classic#2809 Signed-off-by: Steve Peters <[email protected]>
Related with this issue #2808 (comment) and this error in the buildfarm https://build.osrfoundation.org/job/gazebo-ci-pr_any-homebrew-amd64/2057/console
Signed-off-by: Alejandro Hernández [email protected]