This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
[Gazebo9] More enhancement for Windows build #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Sean! changes looks good to me. Let me run another round of CI before merging. @osrf-jenkins run tests |
|
The abi-checker killed the memory in CI, I'm not worried about. The Mac build is waiting #2809. Windows is happy. Let's wait a bit more for the linux ones. |
|
Thanks! And hope this can be forward-port to Gazebo11 if they also make sense there. :) |
j-rivero
approved these changes
Aug 10, 2020
chapulina
approved these changes
Aug 11, 2020
Tobias-Fischer
added a commit
to Tobias-Fischer/gazebo
that referenced
this pull request
May 2, 2021
Tobias-Fischer
added a commit
to Tobias-Fischer/gazebo
that referenced
this pull request
May 2, 2021
scpeters
added a commit
that referenced
this pull request
Oct 28, 2021
* Forward port #2789 part 1 * Forward port #2789 part 2 * Fix line length and compiler warning Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binfolder by convention.tar.exein Windows 10 (yes, there is atar.exewith Windows) to unpack the downloaded asset. This could be a way to resolve this gap: [Gazebo9][Windows] ModelDatabase::GetModelPath implementation is incomplete on Windows build. #2611