fix(gatsby): show multiple invites together & at end where people are more likely to see them (#28450) #28541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more likely to see them (#28450) * fix(gatsby): show multiple invites together & at end where people are more likely to see them * Add telemetry * update copy from suggestions by @DSchau * Actually stop listening * Update packages/gatsby/src/utils/show-experiment-notice.ts Co-authored-by: Matt Kane <[email protected]> * Add test for generating the message * rewrite messages & make shorter * make all the things happy * update flag * This breaking windows?? * Don't use explicit \n to see if that helps snapshot * Maybe jest is fine w/ explicit new-lines 🤷♂️ * Strip ansi for tests * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/run-page-queries.ts Co-authored-by: Michal Piechowiak <[email protected]> * use trackCLI not trackFeatureIsUsed * only store that we showed the invite when we actually do show the invite * Call code directly from webpack's done callback * mock in jest * be more explicit about how the caching behavior changes * Show full code sample per @pelikhan's feedback * typescript fixes * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Matt Kane <[email protected]> Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Michal Piechowiak <[email protected]> (cherry picked from commit 7e734cc)
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
KyleAMathews
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #28450 to the 2.28 release branch
(cherry picked from commit 7e734cc)