fix(gatsby): show multiple invites together & at end where people are more likely to see them #28450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more likely to see them
gatsbot
bot
added
the
status: triage needed
pvdz
suggested changes
Dec 3, 2020
There was a problem hiding this comment.
I think the emitter.off needs a little work.
Overall I like the grouping of these messages but I worry that people will never see them if they are only shown at the end. Like what happens when you abort?
Does this system have no tests? No snapshots to update? Could we have some?
ascorbic
added
topic: cli
ascorbic
reviewed
Dec 3, 2020
pvdz
previously approved these changes
Dec 3, 2020
pieh
reviewed
Dec 7, 2020
pieh
reviewed
Dec 7, 2020
pieh
reviewed
Dec 7, 2020
| } | ||
| } | ||
|
|
||
| emitter.on(`COMPILATION_DONE`, showNotices) |
There was a problem hiding this comment.
Can we avoid executing code at import time? This leads to weird and hard to debug problems later on when shuffling imports that potentially impact how things work together. In fact I would propose to not even use COMPILATION_DONE callback at all and just call showNotices() in webpack's DONE hook handler (on first compile only?)
There was a problem hiding this comment.
yeah we could do that 👍
pieh
reviewed
Dec 7, 2020
pieh
reviewed
Dec 7, 2020
pieh
reviewed
Dec 7, 2020
pieh
reviewed
Dec 7, 2020
pieh
reviewed
Dec 7, 2020
Co-authored-by: Michal Piechowiak <[email protected]>
Co-authored-by: Michal Piechowiak <[email protected]>
KyleAMathews
force-pushed
the
consolidate-invites
branch
from
b4667e7 to
a9560a2
Compare
pieh
reviewed
Dec 8, 2020
Co-authored-by: Michal Piechowiak <[email protected]>
pieh
previously approved these changes
Dec 8, 2020
pieh
added
bot: merge on green
pieh
reviewed
Dec 8, 2020
pieh
added
the
bot: merge on green
pieh
pushed a commit
that referenced
this pull request
Dec 8, 2020
… more likely to see them (#28450) * fix(gatsby): show multiple invites together & at end where people are more likely to see them * Add telemetry * update copy from suggestions by @DSchau * Actually stop listening * Update packages/gatsby/src/utils/show-experiment-notice.ts Co-authored-by: Matt Kane <[email protected]> * Add test for generating the message * rewrite messages & make shorter * make all the things happy * update flag * This breaking windows?? * Don't use explicit \n to see if that helps snapshot * Maybe jest is fine w/ explicit new-lines 🤷♂️ * Strip ansi for tests * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/run-page-queries.ts Co-authored-by: Michal Piechowiak <[email protected]> * use trackCLI not trackFeatureIsUsed * only store that we showed the invite when we actually do show the invite * Call code directly from webpack's done callback * mock in jest * be more explicit about how the caching behavior changes * Show full code sample per @pelikhan's feedback * typescript fixes * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Matt Kane <[email protected]> Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Michal Piechowiak <[email protected]> (cherry picked from commit 7e734cc)
pieh
pushed a commit
that referenced
this pull request
Dec 10, 2020
… more likely to see them (#28450) (#28541) * fix(gatsby): show multiple invites together & at end where people are more likely to see them * Add telemetry * update copy from suggestions by @DSchau * Actually stop listening * Update packages/gatsby/src/utils/show-experiment-notice.ts Co-authored-by: Matt Kane <[email protected]> * Add test for generating the message * rewrite messages & make shorter * make all the things happy * update flag * This breaking windows?? * Don't use explicit \n to see if that helps snapshot * Maybe jest is fine w/ explicit new-lines 🤷♂️ * Strip ansi for tests * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/run-page-queries.ts Co-authored-by: Michal Piechowiak <[email protected]> * use trackCLI not trackFeatureIsUsed * only store that we showed the invite when we actually do show the invite * Call code directly from webpack's done callback * mock in jest * be more explicit about how the caching behavior changes * Show full code sample per @pelikhan's feedback * typescript fixes * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Matt Kane <[email protected]> Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Michal Piechowiak <[email protected]> (cherry picked from commit 7e734cc) Co-authored-by: Kyle Mathews <[email protected]>
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
… more likely to see them (gatsbyjs#28450) * fix(gatsby): show multiple invites together & at end where people are more likely to see them * Add telemetry * update copy from suggestions by @DSchau * Actually stop listening * Update packages/gatsby/src/utils/show-experiment-notice.ts Co-authored-by: Matt Kane <[email protected]> * Add test for generating the message * rewrite messages & make shorter * make all the things happy * update flag * This breaking windows?? * Don't use explicit \n to see if that helps snapshot * Maybe jest is fine w/ explicit new-lines 🤷♂️ * Strip ansi for tests * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/run-page-queries.ts Co-authored-by: Michal Piechowiak <[email protected]> * use trackCLI not trackFeatureIsUsed * only store that we showed the invite when we actually do show the invite * Call code directly from webpack's done callback * mock in jest * be more explicit about how the caching behavior changes * Show full code sample per @pelikhan's feedback * typescript fixes * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/services/initialize.ts Co-authored-by: Matt Kane <[email protected]> Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Michal Piechowiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also track when we show invites so we get a sense of how often that is happening