-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: recently added support for "new"
headless mode fails with Playwright
#1534
Comments
"new"
headless mode fails with Playwright (#1525) (dgrebb/backstopjs#73)"new"
headless mode fails with Playwright
Found and fixing 👍 |
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
dgrebb
added a commit
to dgrebb/BackstopJS
that referenced
this issue
Dec 24, 2023
garris
pushed a commit
that referenced
this issue
Dec 24, 2023
* feat: defaults puppeteer to `new` headless mode (garris/BackstopJS/#1525) * fix: corrects playwr typo in `test/configs/playwright.json` * fix: supports string in `headless: "new"` for Playwright (#1534) * fix: corrects path for integration test pass/fail message scripts * documentation: update README with `new` headless mode information * documentation: adjust comment language in runPlaywright
Closed with #1535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
As documented in the README, setting
engineOptions.headless = "new"
is passed to Playwright as expected, but fails.[email protected]
Details
Playwright supports
"new"
headless mode, set as a string, but only by definingignoredDefaultArgs: ["--headless"]
.This isn't well documented, but one can see Playwright's
headless
argument expects a boolean.Deeply burred in a GitHub issue, there is a small example of how to make
"new"
headless mode work:(#1525) (dgrebb#73)
The text was updated successfully, but these errors were encountered: