Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headless mode: deprecation warning after upgrading #1525

Closed
fuhlig opened this issue Dec 21, 2023 · 4 comments
Closed

Headless mode: deprecation warning after upgrading #1525

fuhlig opened this issue Dec 21, 2023 · 4 comments

Comments

@fuhlig
Copy link
Contributor

fuhlig commented Dec 21, 2023 •
edited
Loading

After the upgraded Puppeteer dependency with the latest 6.3.1 release, Puppeteer/Chrome throws the following deprecation warning:
image

docs:
https://developer.chrome.com/docs/chromium/new-headless?hl=en

While this is documented in the Backstop docs, it might be a better option is setting the headless mode to new by default to avoid deprecation warnings (and potential failures in future versions).
@dgrebb
Copy link
Contributor

dgrebb commented Dec 21, 2023

@fuhlig I agree, and know this is planned for a future release. "new" is not new so much anymore ¯_(ツ)_/¯

I'll look into submitting a PR for the change today.

@dgrebb dgrebb mentioned this issue Dec 21, 2023
Closed
@fuhlig
Copy link
Contributor Author

fuhlig commented Dec 21, 2023

Cheers mate

dgrebb added a commit to dgrebb/BackstopJS that referenced this issue Dec 23, 2023
@dgrebb
feat: defaults puppeteer and playwright to new headless mode (garri…
f67ee2a 
…s/BackstopJS/garris#1525)
dgrebb added a commit to dgrebb/BackstopJS that referenced this issue Dec 24, 2023
@dgrebb
feat: defaults puppeteer and playwright to new headless mode (garri…
594633b 
…s/BackstopJS/garris#1525)
dgrebb added a commit to dgrebb/BackstopJS that referenced this issue Dec 24, 2023
@dgrebb
feat: defaults puppeteer and playwright to new headless mode (garri…
650c31b 
…s/BackstopJS/garris#1525)
@dgrebb dgrebb mentioned this issue Dec 24, 2023
Closed
dgrebb added a commit to dgrebb/BackstopJS that referenced this issue Dec 24, 2023
@dgrebb
feat: defaults puppeteer to new headless mode (garris/BackstopJS/ga…
fd6b9c9 
…rris#1525)
This was referenced Dec 24, 2023
Closed
Merged
garris pushed a commit that referenced this issue Dec 24, 2023
@dgrebb
PATCH: Feature/1525 headless mode deprecation (#1535)
885a68d 
* feat: defaults puppeteer to `new` headless mode (garris/BackstopJS/#1525)

* fix: corrects playwr typo in `test/configs/playwright.json`

* fix: supports string in `headless: "new"` for Playwright (#1534)

* fix: corrects path for integration test pass/fail message scripts

* documentation: update README with `new` headless mode information

* documentation: adjust comment language in runPlaywright
@dgrebb
Copy link
Contributor

dgrebb commented Dec 31, 2023

@fuhlig I just remembered to follow up! This can probably be closed — check out #1535 and backstop@latest (6.3.3).

There are some notes in the PR about Playwright to be aware of. We didn't think it was a good idea to default that runner to 'new' just yet.

Happy new year!

@fuhlig
Copy link
Contributor Author

fuhlig commented Dec 31, 2023

Awesome, thanks @dgrebb!
Will check it out next week

Have a happy new year!

@fuhlig fuhlig closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgrebb @fuhlig