Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divide by zero on looking up resource quota for uninitialised issuer #92

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Fix divide by zero on looking up non-existing resource quota.
This may happen if the certificates reconciliation starts before the issuer is updated.

Which issue(s) this PR fixes:
Fixes #91

Special notes for your reviewer:

Release note:

Fix rare divide by zero on looking up resource quota for uninitialised issuer

@MartinWeindel MartinWeindel requested a review from a team as a code owner September 13, 2021 14:35
@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 13, 2021
@MartinWeindel MartinWeindel force-pushed the fix/resource-quota-divide-by-zero branch from e70e280 to b0a9dfb Compare September 14, 2021 09:41
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2021
@MartinWeindel MartinWeindel merged commit 14b3be9 into master Sep 14, 2021
@MartinWeindel MartinWeindel deleted the fix/resource-quota-divide-by-zero branch September 14, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observed a panic: "integer divide by zero" (runtime error: integer divide by zero)
4 participants