fix divide by zero on looking up resource quota for uninitialized issuer

gardener · Sep 13, 2021 · e70e280 · e70e280
1 parent 1b30c7e
commit e70e280
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pkg/controller/issuer/certificate/reconciler.go b/pkg/controller/issuer/certificate/reconciler.go
@@ -412,7 +412,12 @@ func (r *certReconciler) obtainCertificateAndPendingACME(logctx logger.LogContex
 	}
 
 	if accepted, requestsPerDayQuota := r.support.TryAcceptCertificateRequest(issuerKey); !accepted {
-		waitMinutes := 1440 / requestsPerDayQuota / 2
+		waitMinutes := 1
+		if requestsPerDayQuota == 0 {
+			err := fmt.Errorf("request quota lookup failed for issuer %s. Retrying in %d min. ", waitMinutes, issuerKey)
+			return r.recheck(logctx, obj, api.StatePending, err, time.Duration(waitMinutes)*time.Minute)
+		}
+		waitMinutes = 1440 / requestsPerDayQuota / 2
 		if waitMinutes < 5 {
 			waitMinutes = 5
 		}

diff --git a/pkg/controller/issuer/core/support.go b/pkg/controller/issuer/core/support.go
@@ -353,6 +353,8 @@ func (s *Support) Failed(logger logger.LogContext, obj resources.Object, state s
 
 // SucceededAndTriggerCertificates handles succeeded and trigger certificates.
 func (s *Support) SucceededAndTriggerCertificates(logger logger.LogContext, obj resources.Object, itype *string, regRaw []byte) reconcile.Status {
+	s.RememberIssuerQuotas(obj.ClusterKey(), obj.Data().(*api.Issuer).Spec.RequestsPerDayQuota)
+
 	s.reportAllCertificateMetrics()
 	s.triggerCertificates(logger, s.ToIssuerKey(obj.ClusterKey()))